* [PATCH iproute2-next] bridge: mdb: Remove double space in MDB dump
@ 2023-02-06 14:21 Ido Schimmel
2023-02-06 23:10 ` Nikolay Aleksandrov
2023-02-07 16:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Ido Schimmel @ 2023-02-06 14:21 UTC (permalink / raw)
To: netdev; +Cc: stephen, dsahern, razor, mlxsw, Ido Schimmel
There is an extra space after the "proto" field. Remove it.
Before:
# bridge -d mdb
dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1
After:
# bridge -d mdb
dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
bridge/mdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bridge/mdb.c b/bridge/mdb.c
index f323cd091fcc..9b5503657178 100644
--- a/bridge/mdb.c
+++ b/bridge/mdb.c
@@ -221,7 +221,7 @@ static void print_mdb_entry(FILE *f, int ifindex, const struct br_mdb_entry *e,
__u8 rtprot = rta_getattr_u8(tb[MDBA_MDB_EATTR_RTPROT]);
SPRINT_BUF(rtb);
- print_string(PRINT_ANY, "protocol", " proto %s ",
+ print_string(PRINT_ANY, "protocol", " proto %s",
rtnl_rtprot_n2a(rtprot, rtb, sizeof(rtb)));
}
}
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2-next] bridge: mdb: Remove double space in MDB dump
2023-02-06 14:21 [PATCH iproute2-next] bridge: mdb: Remove double space in MDB dump Ido Schimmel
@ 2023-02-06 23:10 ` Nikolay Aleksandrov
2023-02-07 16:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Aleksandrov @ 2023-02-06 23:10 UTC (permalink / raw)
To: Ido Schimmel, netdev; +Cc: stephen, dsahern, mlxsw
On 2/6/23 16:21, Ido Schimmel wrote:
> There is an extra space after the "proto" field. Remove it.
>
> Before:
>
> # bridge -d mdb
> dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1
>
> After:
>
> # bridge -d mdb
> dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> bridge/mdb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bridge/mdb.c b/bridge/mdb.c
> index f323cd091fcc..9b5503657178 100644
> --- a/bridge/mdb.c
> +++ b/bridge/mdb.c
> @@ -221,7 +221,7 @@ static void print_mdb_entry(FILE *f, int ifindex, const struct br_mdb_entry *e,
> __u8 rtprot = rta_getattr_u8(tb[MDBA_MDB_EATTR_RTPROT]);
> SPRINT_BUF(rtb);
>
> - print_string(PRINT_ANY, "protocol", " proto %s ",
> + print_string(PRINT_ANY, "protocol", " proto %s",
> rtnl_rtprot_n2a(rtprot, rtb, sizeof(rtb)));
> }
> }
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2-next] bridge: mdb: Remove double space in MDB dump
2023-02-06 14:21 [PATCH iproute2-next] bridge: mdb: Remove double space in MDB dump Ido Schimmel
2023-02-06 23:10 ` Nikolay Aleksandrov
@ 2023-02-07 16:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-07 16:50 UTC (permalink / raw)
To: Ido Schimmel; +Cc: netdev, stephen, dsahern, razor, mlxsw
Hello:
This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:
On Mon, 6 Feb 2023 16:21:52 +0200 you wrote:
> There is an extra space after the "proto" field. Remove it.
>
> Before:
>
> # bridge -d mdb
> dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1
>
> [...]
Here is the summary with links:
- [iproute2-next] bridge: mdb: Remove double space in MDB dump
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=e7baae08a901
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-07 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-06 14:21 [PATCH iproute2-next] bridge: mdb: Remove double space in MDB dump Ido Schimmel
2023-02-06 23:10 ` Nikolay Aleksandrov
2023-02-07 16:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).