From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Andrew Lunn <andrew@lunn.ch>, NXP Linux Team <linux-imx@nxp.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net: fec: Don't fail on missing optional phy-reset-gpios
Date: Mon, 6 Feb 2023 22:30:27 -0800 [thread overview]
Message-ID: <20230206223027.0d65ce10@kernel.org> (raw)
In-Reply-To: <20230203132102.313314-1-alexander.stein@ew.tq-group.com>
On Fri, 3 Feb 2023 14:21:02 +0100 Alexander Stein wrote:
> The conversion to gpio descriptors accidentally removed the short return
> if there is no 'phy-reset-gpios' property, leading to the error
>
> fec 30be0000.ethernet: error -ENOENT: failed to get phy-reset-gpios
>
> This is especially the case when the PHY reset GPIO is specified in
> the PHY node itself.
>
> Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Fixed around the same time by commit d7b5e5dd669436 right?
next prev parent reply other threads:[~2023-02-07 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:21 [PATCH 1/1] net: fec: Don't fail on missing optional phy-reset-gpios Alexander Stein
2023-02-07 6:30 ` Jakub Kicinski [this message]
2023-02-07 13:24 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206223027.0d65ce10@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).