* [PATCH bpf-next] virtio_net: update xdp_features with xdp multi-buff
@ 2023-02-07 9:53 Lorenzo Bianconi
2023-02-07 14:31 ` Michael S. Tsirkin
2023-02-07 22:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2023-02-07 9:53 UTC (permalink / raw)
To: bpf
Cc: netdev, ast, daniel, andrii, davem, kuba, pabeni, edumazet,
lorenzo.bianconi, mst, jasowang, hawk, john.fastabend,
virtualization
Now virtio-net supports xdp multi-buffer so add it to xdp_features
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
drivers/net/virtio_net.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 692dff071782..ddc3dc7ea73c 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -3281,7 +3281,7 @@ static int virtnet_xdp_set(struct net_device *dev, struct bpf_prog *prog,
virtnet_clear_guest_offloads(vi);
}
if (!old_prog)
- xdp_features_set_redirect_target(dev, false);
+ xdp_features_set_redirect_target(dev, true);
} else {
xdp_features_clear_redirect_target(dev);
vi->xdp_enabled = false;
@@ -3940,8 +3940,10 @@ static int virtnet_probe(struct virtio_device *vdev)
INIT_WORK(&vi->config_work, virtnet_config_changed_work);
spin_lock_init(&vi->refill_lock);
- if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
+ if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF)) {
vi->mergeable_rx_bufs = true;
+ dev->xdp_features |= NETDEV_XDP_ACT_RX_SG;
+ }
if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_NOTF_COAL)) {
vi->rx_usecs = 0;
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] virtio_net: update xdp_features with xdp multi-buff
2023-02-07 9:53 [PATCH bpf-next] virtio_net: update xdp_features with xdp multi-buff Lorenzo Bianconi
@ 2023-02-07 14:31 ` Michael S. Tsirkin
2023-02-07 22:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2023-02-07 14:31 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: bpf, netdev, ast, daniel, andrii, davem, kuba, pabeni, edumazet,
lorenzo.bianconi, jasowang, hawk, john.fastabend, virtualization
On Tue, Feb 07, 2023 at 10:53:40AM +0100, Lorenzo Bianconi wrote:
> Now virtio-net supports xdp multi-buffer so add it to xdp_features
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
makes sense
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 692dff071782..ddc3dc7ea73c 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3281,7 +3281,7 @@ static int virtnet_xdp_set(struct net_device *dev, struct bpf_prog *prog,
> virtnet_clear_guest_offloads(vi);
> }
> if (!old_prog)
> - xdp_features_set_redirect_target(dev, false);
> + xdp_features_set_redirect_target(dev, true);
> } else {
> xdp_features_clear_redirect_target(dev);
> vi->xdp_enabled = false;
> @@ -3940,8 +3940,10 @@ static int virtnet_probe(struct virtio_device *vdev)
> INIT_WORK(&vi->config_work, virtnet_config_changed_work);
> spin_lock_init(&vi->refill_lock);
>
> - if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
> + if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF)) {
> vi->mergeable_rx_bufs = true;
> + dev->xdp_features |= NETDEV_XDP_ACT_RX_SG;
> + }
>
> if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_NOTF_COAL)) {
> vi->rx_usecs = 0;
> --
> 2.39.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] virtio_net: update xdp_features with xdp multi-buff
2023-02-07 9:53 [PATCH bpf-next] virtio_net: update xdp_features with xdp multi-buff Lorenzo Bianconi
2023-02-07 14:31 ` Michael S. Tsirkin
@ 2023-02-07 22:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-07 22:20 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: bpf, netdev, ast, daniel, andrii, davem, kuba, pabeni, edumazet,
lorenzo.bianconi, mst, jasowang, hawk, john.fastabend,
virtualization
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Tue, 7 Feb 2023 10:53:40 +0100 you wrote:
> Now virtio-net supports xdp multi-buffer so add it to xdp_features
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/net/virtio_net.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Here is the summary with links:
- [bpf-next] virtio_net: update xdp_features with xdp multi-buff
https://git.kernel.org/bpf/bpf-next/c/30bbf891f1b8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-07 22:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-07 9:53 [PATCH bpf-next] virtio_net: update xdp_features with xdp multi-buff Lorenzo Bianconi
2023-02-07 14:31 ` Michael S. Tsirkin
2023-02-07 22:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).