From: Jakub Kicinski <kuba@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Xin Long <lucien.xin@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
dev@openvswitch.org, tipc-discussion@lists.sourceforge.net,
Andy Shevchenko <andy@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Pravin B Shelar <pshelar@ovn.org>, Jon Maloy <jmaloy@redhat.com>,
Ying Xue <ying.xue@windriver.com>,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v2 1/3] string_helpers: Move string_is_valid() to the header
Date: Tue, 7 Feb 2023 20:29:45 -0800 [thread overview]
Message-ID: <20230207202945.155c6608@kernel.org> (raw)
In-Reply-To: <20230206161314.15667-1-andriy.shevchenko@linux.intel.com>
On Mon, 6 Feb 2023 18:13:12 +0200 Andy Shevchenko wrote:
> +static inline bool string_is_valid(const char *s, int len)
> +{
> + return memchr(s, '\0', len) ? true : false;
> +}
I was tempted to suggest adding a kdoc, but perhaps the function
doesn't have an obvious enough name? Maybe we should call the helper
string_is_terminated(), instead?
next prev parent reply other threads:[~2023-02-08 4:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 16:13 [PATCH net-next v2 1/3] string_helpers: Move string_is_valid() to the header Andy Shevchenko
2023-02-06 16:13 ` [PATCH net-next v2 2/3] genetlink: Use string_is_valid() helper Andy Shevchenko
2023-02-06 16:13 ` [PATCH net-next v2 3/3] openvswitch: " Andy Shevchenko
2023-02-08 4:29 ` Jakub Kicinski [this message]
2023-02-08 11:15 ` [PATCH net-next v2 1/3] string_helpers: Move string_is_valid() to the header Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207202945.155c6608@kernel.org \
--to=kuba@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=simon.horman@corigine.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).