From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AD94C6379F for ; Wed, 8 Feb 2023 03:03:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbjBHDDa (ORCPT ); Tue, 7 Feb 2023 22:03:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230307AbjBHDDW (ORCPT ); Tue, 7 Feb 2023 22:03:22 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 748D23E634 for ; Tue, 7 Feb 2023 19:03:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D4D2BCE1F20 for ; Wed, 8 Feb 2023 03:03:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1694FC433EF; Wed, 8 Feb 2023 03:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675825397; bh=cqUmVFvKnMIzG3uueNcI1TnmUbHH+Hxc2+9KMnuQ3SI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DpaAqawvV9fMsG/khV21Wj2SRH2SctfrpJ/rVOfOzQmBeQ+pbyGyB+dSYTbVaaf0e kme5KWx4nebvuKLB3B7QIEOgtmwlLMeHV6auZzcMc/hYV3wvL4EM46s0qDD5CyVHQc jWHILy41cu3yqtPcAgVM7+k8ExcfYZD7//j3ualR2OwLszZ56YaCAujTZQ9rLcbebh lnsBxGASNwCABCSqPyPshmDXkVAMHGzJmpgcjQy0BDdrmVge4nmNBbUoYOwoPioNXx 57wxDZaYjO0CGFazlVhXN3asrd7suUKEd+oti3dnb5q/hFoxDAP/fGfNzZ+nZqKBd7 BNBcRXlVN1iXA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Shay Drory , Moshe Shemesh Subject: [net 08/10] net/mlx5: fw_tracer, Clear load bit when freeing string DBs buffers Date: Tue, 7 Feb 2023 19:03:00 -0800 Message-Id: <20230208030302.95378-9-saeed@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230208030302.95378-1-saeed@kernel.org> References: <20230208030302.95378-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Shay Drory Whenever the driver is reading the string DBs into buffers, the driver is setting the load bit, but the driver never clears this bit. As a result, in case load bit is on and the driver query the device for new string DBs, the driver won't read again the string DBs. Fix it by clearing the load bit when query the device for new string DBs. Fixes: 2d69356752ff ("net/mlx5: Add support for fw live patch event") Signed-off-by: Shay Drory Reviewed-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c index 21831386b26e..d82e98a0cdfa 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c @@ -64,6 +64,7 @@ static int mlx5_query_mtrc_caps(struct mlx5_fw_tracer *tracer) MLX5_GET(mtrc_cap, out, num_string_trace); tracer->str_db.num_string_db = MLX5_GET(mtrc_cap, out, num_string_db); tracer->owner = !!MLX5_GET(mtrc_cap, out, trace_owner); + tracer->str_db.loaded = false; for (i = 0; i < tracer->str_db.num_string_db; i++) { mtrc_cap_sp = MLX5_ADDR_OF(mtrc_cap, out, string_db_param[i]); -- 2.39.1