From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 004CDC636CC for ; Wed, 8 Feb 2023 03:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230321AbjBHDVY (ORCPT ); Tue, 7 Feb 2023 22:21:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbjBHDVX (ORCPT ); Tue, 7 Feb 2023 22:21:23 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2F5F4C02 for ; Tue, 7 Feb 2023 19:21:20 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id a5so9188308pfv.10 for ; Tue, 07 Feb 2023 19:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nln0p+/pxQmjacA2p5dBzK6VCMWzMygwZUeFqT3/anE=; b=DqOfkHoA0J5z0g1S1qaoTjtTut11MKkbAFmdMqahDZMV1ov7RykuP6O4DtvcLqmknH hCRSjx2ZvJg4g6kKTuZGQPteXumXYPooudt1Mf9atgvKkpwCk4OPen0iVnQhfFnUKaS+ /ESszEVIBdK02gMw+RSULn1XbjauRyLfPp3TUGjZ3ErMoRco9m13XGFcOXLc0oOiYTsp OmIWEdbAI4ac15Y/AslbIdMVDs1+JMOPZYPb94665cB8NkoptfclDfm1HZMNg3YiJBrO ONI69xrQVJualkb3xT+OVpqq9a3/nNO813QGQSfW1en0AoPJoQUWWxkwHXEmBCgr+hlk 5TLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nln0p+/pxQmjacA2p5dBzK6VCMWzMygwZUeFqT3/anE=; b=pqF/f8ex0K8Erf53+Oi6kY3o4FNIvKZa28f8XuSrdzQkjBa4haT2nfGFNTvx7m4t8H vI6wwunR/qT2e9qiy5scPJgxVG57k7Oe1kuYuHf4lIVFiUFHr2xO0KMlLuGPCSocw/8e wkTPOHShxPHERAQMr2xzMdjfFBlNTOyOZ8PZinyDo7JZLWXyiyoHvSOJTkOC9Zc+lBzu xuDbbg5vZDxbvAwl9bGTjv2YkHefsYmf3ieW/FUS4EMj0+H/k08gfeFM5migYVvjI3kq 6eQEHSxviMBgfkiNjyzlR8gqfH4AAZmgEO+LhnE9rWqVQHZvkyJkw0tKMKHx8AKBZlIG d+aA== X-Gm-Message-State: AO0yUKV0iRUZb53OdhjOLhDJan8ugZVcM8MfDm2hO03cbphNQeuCuN/X 42mFVDOMageGDEbVUeSRRsmlIrdEdlnHHg== X-Google-Smtp-Source: AK7set8mdM7XoWEOUoO/vezpNKKw0F+7MX7J1b+8p89MxyzPMOldGso09KBbARwo1dGHXNKbIRG6ZQ== X-Received: by 2002:a62:6488:0:b0:578:ac9f:79a9 with SMTP id y130-20020a626488000000b00578ac9f79a9mr4397343pfb.15.1675826479796; Tue, 07 Feb 2023 19:21:19 -0800 (PST) Received: from Laptop-X1.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id a9-20020a056a001d0900b00575caf80d08sm9901342pfx.31.2023.02.07.19.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 19:21:19 -0800 (PST) From: Hangbin Liu To: netdev@vger.kernel.org Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Shuah Khan , David Ahern , Petr Machata , Hangbin Liu Subject: [PATCH net] selftests: forwarding: lib: quote the sysctl values Date: Wed, 8 Feb 2023 11:21:10 +0800 Message-Id: <20230208032110.879205-1-liuhangbin@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When set/restore sysctl value, we should quote the value as some keys may have multi values, e.g. net.ipv4.ping_group_range Fixes: f5ae57784ba8 ("selftests: forwarding: lib: Add sysctl_set(), sysctl_restore()") Signed-off-by: Hangbin Liu --- tools/testing/selftests/net/forwarding/lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh index 1c4f866de7d7..3d8e4ebda1b6 100755 --- a/tools/testing/selftests/net/forwarding/lib.sh +++ b/tools/testing/selftests/net/forwarding/lib.sh @@ -914,14 +914,14 @@ sysctl_set() local value=$1; shift SYSCTL_ORIG[$key]=$(sysctl -n $key) - sysctl -qw $key=$value + sysctl -qw $key="$value" } sysctl_restore() { local key=$1; shift - sysctl -qw $key=${SYSCTL_ORIG["$key"]} + sysctl -qw $key="${SYSCTL_ORIG[$key]}" } forwarding_enable() -- 2.38.1