netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	linux-rdma@vger.kernel.org, Leon Romanovsky <leonro@nvidia.com>,
	netdev@vger.kernel.org
Subject: Re: pull-request: mlx5-next netdev notifier deadlock 2023-02-07
Date: Wed, 8 Feb 2023 19:12:50 -0800	[thread overview]
Message-ID: <20230208191250.45b23b6f@kernel.org> (raw)
In-Reply-To: <20230208005626.72930-1-saeed@kernel.org>

On Tue,  7 Feb 2023 16:56:26 -0800 Saeed Mahameed wrote:
> @@ -674,6 +675,7 @@ struct mlx5e_resources {
>  	} hw_objs;
>  	struct devlink_port dl_port;
>  	struct net_device *uplink_netdev;
> +	struct mutex uplink_netdev_lock;

Is this your preferred resolution?

diff --cc include/linux/mlx5/driver.h
index 91e8160ed087,cc48aa308269..000000000000
--- a/include/linux/mlx5/driver.h
+++ b/include/linux/mlx5/driver.h
@@@ -670,11 -673,11 +671,12 @@@ struct mlx5e_resources 
                u32                        mkey;
                struct mlx5_sq_bfreg       bfreg;
        } hw_objs;
        struct devlink_port dl_port;
        struct net_device *uplink_netdev;
+       struct mutex uplink_netdev_lock;
 +      struct mlx5_crypto_dek_priv *dek_priv;
  };
  
  enum mlx5_sw_icm_type {
        MLX5_SW_ICM_TYPE_STEERING,
        MLX5_SW_ICM_TYPE_HEADER_MODIFY,

  reply	other threads:[~2023-02-09  3:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08  0:56 pull-request: mlx5-next netdev notifier deadlock 2023-02-07 Saeed Mahameed
2023-02-09  3:12 ` Jakub Kicinski [this message]
2023-02-09  3:16   ` Jakub Kicinski
2023-02-09  3:46     ` Saeed Mahameed
2023-02-09  4:27       ` Jakub Kicinski
2023-02-09  4:51         ` Saeed Mahameed
2023-02-09  3:42   ` Saeed Mahameed
2023-02-09  5:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230208191250.45b23b6f@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jgg@nvidia.com \
    --cc=leonro@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeed@kernel.org \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).