From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iwl4965: Add missing check for create_singlethread_workqueue
Date: Wed, 8 Feb 2023 21:16:58 +0100 [thread overview]
Message-ID: <20230208201658.GA1435569@wp.pl> (raw)
In-Reply-To: <20230208063032.42763-1-jiasheng@iscas.ac.cn>
On Wed, Feb 08, 2023 at 02:30:31PM +0800, Jiasheng Jiang wrote:
> Add the check for the return value of the create_singlethread_workqueue
> in order to avoid NULL pointer dereference.
>
> Fixes: b481de9ca074 ("[IWLWIFI]: add iwlwifi wireless drivers")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> static void
> @@ -6618,7 +6622,11 @@ il4965_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> goto out_disable_msi;
> }
>
> - il4965_setup_deferred_work(il);
> + err = il4965_setup_deferred_work(il);
> + if (err) {
> + goto out_free_irq;
> + }
{} not needded.
next prev parent reply other threads:[~2023-02-08 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 6:30 [PATCH 1/2] iwl4965: Add missing check for create_singlethread_workqueue Jiasheng Jiang
2023-02-08 6:30 ` [PATCH 2/2] iwl3945: " Jiasheng Jiang
2023-02-08 20:17 ` Stanislaw Gruszka
2023-02-13 15:16 ` [2/2] wifi: " Kalle Valo
2023-02-08 20:16 ` Stanislaw Gruszka [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-02-09 1:11 [PATCH 1/2] iwl4965: " Jiasheng Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208201658.GA1435569@wp.pl \
--to=stf_xl@wp.pl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiasheng@iscas.ac.cn \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).