From: Jakub Kicinski <kuba@kernel.org>
To: Praveen Kaligineedi <pkaligineedi@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Jeroen de Borst <jeroendb@google.com>
Subject: Re: [PATCH net-next 2/4] gve: Add XDP DROP and TX support for GQI-QPL format
Date: Wed, 8 Feb 2023 21:54:52 -0800 [thread overview]
Message-ID: <20230208215452.67225287@kernel.org> (raw)
In-Reply-To: <20230207210058.2257219-3-pkaligineedi@google.com>
On Tue, 7 Feb 2023 13:00:56 -0800 Praveen Kaligineedi wrote:
> + // Adding/removing a program, need to recreate the queues.
> + if (!netif_carrier_ok(priv->dev)) {
> + rcu_assign_pointer(priv->xdp_prog, prog);
> + goto out;
> + }
> + err = gve_close(priv->dev);
> + if (err)
> + return err;
> +
> + rcu_assign_pointer(priv->xdp_prog, prog);
> + gve_open(priv->dev);
And if open() fails e.g. due to transient memory pressure the machine
drops off the network and success gets returned to user space?
We have been asking driver developers for a while now to allocate
resources first, then try the reconfig.
next prev parent reply other threads:[~2023-02-09 5:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 21:00 [PATCH net-next 0/4] gve: Add XDP support for GQI-QPL format Praveen Kaligineedi
2023-02-07 21:00 ` [PATCH net-next 1/4] gve: XDP support GQI-QPL: helper function changes Praveen Kaligineedi
2023-02-07 21:00 ` [PATCH net-next 2/4] gve: Add XDP DROP and TX support for GQI-QPL format Praveen Kaligineedi
2023-02-09 5:54 ` Jakub Kicinski [this message]
2023-02-14 0:46 ` Maciej Fijalkowski
2023-02-07 21:00 ` [PATCH net-next 3/4] gve: Add XDP REDIRECT " Praveen Kaligineedi
2023-02-14 1:03 ` Maciej Fijalkowski
2023-02-07 21:00 ` [PATCH net-next 4/4] gve: Add AF_XDP zero-copy " Praveen Kaligineedi
2023-02-14 14:46 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208215452.67225287@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jeroendb@google.com \
--cc=netdev@vger.kernel.org \
--cc=pkaligineedi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).