netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: <Ajay.Kathat@microchip.com>
Cc: <heiko.thiery@gmail.com>, <Claudiu.Beznea@microchip.com>,
	<kvalo@kernel.org>, <linux-wireless@vger.kernel.org>,
	<michael@walle.cc>, <netdev@vger.kernel.org>,
	<Amisha.Patel@microchip.com>
Subject: Re: wilc1000 MAC address is 00:00:00:00:00:00
Date: Thu, 9 Feb 2023 13:07:25 -0800	[thread overview]
Message-ID: <20230209130725.0b04a424@kernel.org> (raw)
In-Reply-To: <51134d12-1b06-6d6f-e798-7dd681a8f3ae@microchip.com>

On Thu, 9 Feb 2023 18:51:58 +0000 Ajay.Kathat@microchip.com wrote:
> > netdev should be created with a valid lladdr, is there something
> > wifi-specific here that'd prevalent that? The canonical flow is
> > to this before registering the netdev:
> 
> Here it's the timing in wilc1000 by when the MAC address is available to
> read from NV. NV read is available in "mac_open" net_device_ops instead
> of bus probe function. I think, mostly the operations on netdev which
> make use of mac address are performed after the "mac_open" (I may be
> missing something).
> 
> Does it make sense to assign a random address in probe and later read
> back from NV in mac_open to make use of stored value?

Hard to say, I'd suspect that may be even more confusing than
starting with zeroes. There aren't any hard rules around the
addresses AFAIK, but addrs are visible to user space. So user
space will likely make assumptions based on the most commonly 
observed sequence (reading real addr at probe).

  reply	other threads:[~2023-02-09 21:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 14:24 wilc1000 MAC address is 00:00:00:00:00:00 Heiko Thiery
2023-02-09 17:15 ` Ajay.Kathat
2023-02-09 17:48   ` Jakub Kicinski
2023-02-09 18:51     ` Ajay.Kathat
2023-02-09 21:07       ` Jakub Kicinski [this message]
2023-02-09 21:19         ` Michael Walle
2023-02-10  9:17           ` Heiko Thiery
2023-02-10  9:25             ` Kalle Valo
2023-02-10 19:12               ` Ajay.Kathat
2023-02-10 21:28                 ` Dan Williams
2023-02-15 20:14                   ` Johannes Berg
2023-02-23 10:44                     ` Heiko Thiery
2023-02-23 21:48                       ` Ajay.Kathat
2023-02-09 18:40   ` Heiko Thiery
2023-02-09 19:09     ` Ajay.Kathat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209130725.0b04a424@kernel.org \
    --to=kuba@kernel.org \
    --cc=Ajay.Kathat@microchip.com \
    --cc=Amisha.Patel@microchip.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=heiko.thiery@gmail.com \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).