netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
	"hare@suse.com" <hare@suse.com>,
	David Howells <dhowells@redhat.com>,
	Benjamin Coddington <bcodding@redhat.com>,
	Olga Kornievskaia <kolga@netapp.com>,
	"jmeneghi@redhat.com" <jmeneghi@redhat.com>
Subject: Re: [PATCH v3 1/2] net/handshake: Create a NETLINK service for handling handshake requests
Date: Thu, 9 Feb 2023 18:07:27 -0800	[thread overview]
Message-ID: <20230209180727.0ec328dd@kernel.org> (raw)
In-Reply-To: <5D62859B-76AD-431C-AC93-C42A32EC2B69@oracle.com>

On Thu, 9 Feb 2023 15:43:06 +0000 Chuck Lever III wrote:
> >> @@ -29,6 +29,7 @@
> >> #define NETLINK_RDMA		20
> >> #define NETLINK_CRYPTO		21	/* Crypto layer */
> >> #define NETLINK_SMC		22	/* SMC monitoring */
> >> +#define NETLINK_HANDSHAKE	23	/* transport layer sec handshake requests */  
> > 
> > The extra indirection of genetlink introduces some complications?  
> 
> I don't think it does, necessarily. But neither does it seem
> to add any value (for this use case). <shrug>

Our default is to go for generic netlink, it's where we invest most time
in terms of infrastructure. It can take care of attribute parsing, and
allows user space to dump information about the family (eg. the parsing
policy). Most recently we added support for writing the policies in
(simple) YAML:

https://docs.kernel.org/next/userspace-api/netlink/intro-specs.html

It takes care of a lot of the netlink tedium. If you're willing to make
use of it I'm happy to help converting etc. We merged this stuff last
month, so there are likely sharp edges.

  parent reply	other threads:[~2023-02-10  2:07 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 21:41 [PATCH v3 0/2] Another crack at a handshake upcall mechanism Chuck Lever
2023-02-07 21:41 ` [PATCH v3 1/2] net/handshake: Create a NETLINK service for handling handshake requests Chuck Lever
2023-02-08 16:20   ` Hannes Reinecke
2023-02-09  6:00   ` Jakub Kicinski
2023-02-09 15:43     ` Chuck Lever III
2023-02-09 16:02       ` Paolo Abeni
2023-02-09 16:34         ` Chuck Lever III
2023-02-10 11:41           ` Paolo Abeni
2023-02-10 14:31             ` Chuck Lever III
2023-02-10 15:06               ` Hannes Reinecke
2023-02-10 15:21               ` Paolo Abeni
2023-02-10 15:38                 ` Chuck Lever III
2023-02-12 15:40           ` Jamal Hadi Salim
2023-02-12 17:24             ` Chuck Lever III
2023-02-10  2:07       ` Jakub Kicinski [this message]
2023-02-10 14:17         ` Chuck Lever III
2023-02-10 18:09           ` Jakub Kicinski
2023-02-10 19:04             ` Chuck Lever III
2023-02-10 21:44               ` Jakub Kicinski
2023-02-11 20:55                 ` Chuck Lever III
2023-02-13 21:40                   ` Jakub Kicinski
2023-02-11 12:11             ` Hannes Reinecke
2023-02-13 21:55               ` Jakub Kicinski
2023-02-07 21:41 ` [PATCH v3 2/2] net/tls: Support AF_HANDSHAKE in kTLS Chuck Lever
2023-02-08 16:34   ` Hannes Reinecke
2023-02-08 17:04     ` Chuck Lever III
2023-02-08 17:48     ` Marcel Holtmann
2023-02-14  9:44 ` [PATCH v3 0/2] Another crack at a handshake upcall mechanism Hannes Reinecke
2023-02-14 11:09   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209180727.0ec328dd@kernel.org \
    --to=kuba@kernel.org \
    --cc=bcodding@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=edumazet@google.com \
    --cc=hare@suse.com \
    --cc=jmeneghi@redhat.com \
    --cc=kolga@netapp.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).