From: Jakub Kicinski <kuba@kernel.org>
To: Oz Shlomo <ozsh@nvidia.com>
Cc: <netdev@vger.kernel.org>, Saeed Mahameed <saeedm@nvidia.com>,
Roi Dayan <roid@nvidia.com>, "Jiri Pirko" <jiri@nvidia.com>,
Marcelo Ricardo Leitner <mleitner@redhat.com>,
"Simon Horman" <simon.horman@corigine.com>,
Baowen Zheng <baowen.zheng@corigine.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Edward Cree <ecree.xilinx@gmail.com>
Subject: Re: [PATCH net-next v3 2/9] net/sched: act_pedit, setup offload action for action stats query
Date: Thu, 9 Feb 2023 22:19:06 -0800 [thread overview]
Message-ID: <20230209221906.6a69c79f@kernel.org> (raw)
In-Reply-To: <20230206135442.15671-3-ozsh@nvidia.com>
On Mon, 6 Feb 2023 15:54:35 +0200 Oz Shlomo wrote:
> + for (k = 1; k < tcf_pedit_nkeys(act); k++) {
> + last_cmd = cmd;
> + cmd = tcf_pedit_cmd(act, k);
> +
> + if (cmd != last_cmd) {
> + NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
> + return -EOPNOTSUPP;
> + }
Is there a reason you're comparing to previous and not just always
to the first one - since they all must be the same?
next prev parent reply other threads:[~2023-02-10 6:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 13:54 [PATCH net-next v3 0/9] add support for per action hw stats Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 1/9] net/sched: optimize action stats api calls Oz Shlomo
2023-02-10 2:31 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 2/9] net/sched: act_pedit, setup offload action for action stats query Oz Shlomo
2023-02-06 14:17 ` Simon Horman
2023-02-10 2:31 ` Marcelo Ricardo Leitner
2023-02-10 6:19 ` Jakub Kicinski [this message]
2023-02-12 11:33 ` Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 3/9] net/sched: pass flow_stats instead of multiple stats args Oz Shlomo
2023-02-10 2:32 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 4/9] net/sched: introduce flow_offload action cookie Oz Shlomo
2023-02-10 2:32 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 5/9] net/sched: support per action hw stats Oz Shlomo
2023-02-10 2:32 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 6/9] net/mlx5e: TC, add hw counter to branching actions Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 7/9] net/mlx5e: TC, store tc action cookies per attr Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 8/9] net/mlx5e: TC, map tc action cookie to a hw counter Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 9/9] net/mlx5e: TC, support per action stats Oz Shlomo
2023-02-08 5:29 ` [PATCH net-next v3 0/9] add support for per action hw stats Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209221906.6a69c79f@kernel.org \
--to=kuba@kernel.org \
--cc=baowen.zheng@corigine.com \
--cc=ecree.xilinx@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).