From: Florian Westphal <fw@strlen.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
dev@openvswitch.org, davem@davemloft.net,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Pravin B Shelar <pshelar@ovn.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Florian Westphal <fw@strlen.de>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Ilya Maximets <i.maximets@ovn.org>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCHv2 net-next 0/5] net: move more duplicate code of ovs and tc conntrack into nf_conntrack_ovs
Date: Fri, 10 Feb 2023 11:35:35 +0100 [thread overview]
Message-ID: <20230210103535.GD17303@breakpoint.cc> (raw)
In-Reply-To: <20230209222144.38640609@kernel.org>
Jakub Kicinski <kuba@kernel.org> wrote:
> On Tue, 7 Feb 2023 17:52:05 -0500 Xin Long wrote:
> > We've moved some duplicate code into nf_nat_ovs in:
> >
> > "net: eliminate the duplicate code in the ct nat functions of ovs and tc"
> >
> > This patchset addresses more code duplication in the conntrack of ovs
> > and tc then creates nf_conntrack_ovs for them, and four functions will
> > be extracted and moved into it:
> >
> > nf_ct_handle_fragments()
> > nf_ct_skb_network_trim()
> > nf_ct_helper()
> > nf_ct_add_helper()
>
> Hi Pablo, do you prefer to take this or should we?
Looks like Pablo is very busy atm, I have no objections
if this is applied to net-next.
You may add
Acked-by: Florian Westphal <fw@strlen.de>
if you like.
next prev parent reply other threads:[~2023-02-10 10:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 22:52 [PATCHv2 net-next 0/5] net: move more duplicate code of ovs and tc conntrack into nf_conntrack_ovs Xin Long
2023-02-07 22:52 ` [PATCHv2 net-next 1/5] net: create nf_conntrack_ovs for ovs and tc use Xin Long
2023-02-08 10:15 ` Simon Horman
2023-02-09 14:59 ` Aaron Conole
2023-02-07 22:52 ` [PATCHv2 net-next 2/5] net: extract nf_ct_skb_network_trim function to nf_conntrack_ovs Xin Long
2023-02-08 10:15 ` Simon Horman
2023-02-09 15:00 ` Aaron Conole
2023-02-07 22:52 ` [PATCHv2 net-next 3/5] openvswitch: move key and ovs_cb update out of handle_fragments Xin Long
2023-02-08 10:16 ` Simon Horman
2023-02-09 15:01 ` Aaron Conole
2023-02-07 22:52 ` [PATCHv2 net-next 4/5] net: sched: move frag check and tc_skb_cb " Xin Long
2023-02-08 10:16 ` Simon Horman
2023-02-07 22:52 ` [PATCHv2 net-next 5/5] net: extract nf_ct_handle_fragments to nf_conntrack_ovs Xin Long
2023-02-08 10:17 ` Simon Horman
2023-02-09 15:08 ` Aaron Conole
2023-02-10 6:21 ` [PATCHv2 net-next 0/5] net: move more duplicate code of ovs and tc conntrack into nf_conntrack_ovs Jakub Kicinski
2023-02-10 10:35 ` Florian Westphal [this message]
2023-02-11 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210103535.GD17303@breakpoint.cc \
--to=fw@strlen.de \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=i.maximets@ovn.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=pshelar@ovn.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).