From: Jakub Kicinski <kuba@kernel.org>
To: Harsh Jain <h.jain@amd.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<thomas.lendacky@amd.com>, <Raju.Rangoju@amd.com>,
<Shyam-sundar.S-k@amd.com>, <harshjain.prof@gmail.com>,
<abhijit.gangurde@amd.com>, <puneet.gupta@amd.com>,
<nikhil.agarwal@amd.com>, <tarak.reddy@amd.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH 0/6] net: ethernet: efct Add x3 ethernet driver
Date: Fri, 10 Feb 2023 11:22:02 -0800 [thread overview]
Message-ID: <20230210112202.6a4d6b9f@kernel.org> (raw)
In-Reply-To: <20230210130321.2898-1-h.jain@amd.com>
On Fri, 10 Feb 2023 18:33:15 +0530 Harsh Jain wrote:
> This patch series adds new ethernet network driver for Alveo X3522[1].
> X3 is a low-latency NIC with an aim to deliver the lowest possible
> latency. It accelerates a range of diverse trading strategies
> and financial applications.
Please get this reviewed by people within AMD who know something
about netdev. Ed, Martin, Alejandro, etc.. This driver seems to
share similarities with SFC and you haven't even CCed them.
This pile a 23kLoC has the same issues the community has been
raising in reviews of other drivers from your organization.
We don't have the resources to be engaging with badly behaving,
throw-the-code-over-the-wall-open-source vendors.
next prev parent reply other threads:[~2023-02-10 19:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 13:03 [PATCH 0/6] net: ethernet: efct Add x3 ethernet driver Harsh Jain
2023-02-10 13:03 ` [PATCH 1/6] net: ethernet: efct: New X3 net driver Harsh Jain
2023-02-10 17:00 ` Simon Horman
2023-02-10 13:03 ` [PATCH 2/6] net: ethernet: efct: Add datapath Harsh Jain
2023-02-10 13:03 ` [PATCH 3/6] net: ethernet: efct: Add devlink support Harsh Jain
2023-02-10 13:03 ` [PATCH 4/6] net: ethernet: efct: Add Hardware timestamp support Harsh Jain
2023-02-10 13:03 ` [PATCH 5/6] net: ethernet: efct: Add ethtool support Harsh Jain
2023-02-11 17:05 ` Andrew Lunn
2023-02-10 13:03 ` [PATCH 6/6] net: ethernet: efct: Add maintainer, kconfig, makefile Harsh Jain
2023-02-11 3:32 ` kernel test robot
2023-02-11 6:36 ` kernel test robot
2023-02-11 13:55 ` kernel test robot
2023-02-13 17:02 ` kernel test robot
2023-02-14 12:25 ` kernel test robot
2023-02-10 19:22 ` Jakub Kicinski [this message]
2023-05-09 5:30 ` [PATCH 0/6] net: ethernet: efct Add x3 ethernet driver Jain, Harsh (DCG-ENG)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210112202.6a4d6b9f@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=abhijit.gangurde@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=h.jain@amd.com \
--cc=harshjain.prof@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=pabeni@redhat.com \
--cc=puneet.gupta@amd.com \
--cc=tarak.reddy@amd.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).