netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	linux-wpan@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Guilhem Imberton <guilhem.imberton@qorvo.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH wpan-next 1/6] ieee802154: Add support for user scanning requests
Date: Fri, 10 Feb 2023 23:47:22 +0100	[thread overview]
Message-ID: <20230210234722.4cf0934f@xps-13> (raw)
In-Reply-To: <20230210105925.26c54e15@kernel.org>

Hi Jakub,

kuba@kernel.org wrote on Fri, 10 Feb 2023 10:59:25 -0800:

> On Fri, 10 Feb 2023 11:18:43 +0100 Miquel Raynal wrote:
> > > > +	/* Monitors are not allowed to perform scans */
> > > > +	if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR)      
> > > 
> > > extack ?    
> > 
> > Thanks for pointing at it, I just did know about it. I did convert
> > most of the printk's into extack strings. Shall I keep both or is fine
> > to just keep the extack thing?
> > 
> > For now I've dropped the printk's, please tell me if this is wrong.  
> 
> That's right - just the extack, we don't want duplicated prints.

Thanks for the confirmation.

Series ready, I need to test it further just to verify there is no
unwanted regression, I'll send it early next week.

Thanks,
Miquèl

  reply	other threads:[~2023-02-10 22:47 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 16:00 [PATCH wpan-next 0/6] IEEE 802.15.4 passive scan support Miquel Raynal
2022-11-29 16:00 ` [PATCH wpan-next 1/6] ieee802154: Add support for user scanning requests Miquel Raynal
2022-12-04 22:44   ` Alexander Aring
2022-12-05  9:57     ` Miquel Raynal
2022-12-07 13:27       ` Alexander Aring
2022-12-07 13:44         ` Miquel Raynal
2022-12-08  2:22           ` Alexander Aring
2023-02-04  4:19   ` Jakub Kicinski
2023-02-10 10:18     ` Miquel Raynal
2023-02-10 10:26       ` Stefan Schmidt
2023-02-10 10:35         ` Miquel Raynal
2023-02-10 18:59       ` Jakub Kicinski
2023-02-10 22:47         ` Miquel Raynal [this message]
2023-02-06  1:39   ` Alexander Aring
2023-02-06  9:12     ` Miquel Raynal
2023-02-07  0:33       ` Alexander Aring
2023-02-07 12:55         ` Alexander Aring
2023-02-07 12:57           ` Alexander Aring
2023-02-13 17:35           ` Miquel Raynal
2023-02-14 13:34             ` Alexander Aring
2023-02-14 13:53               ` Alexander Aring
2023-02-14 14:06                 ` Miquel Raynal
2023-02-14 14:46                   ` Miquel Raynal
2023-02-17  4:37                     ` Alexander Aring
2023-02-17  8:49                       ` Miquel Raynal
2023-02-17  4:34                   ` Alexander Aring
2023-02-17  9:02                     ` Miquel Raynal
2023-02-21  2:43                       ` Alexander Aring
2023-02-10 17:21         ` Miquel Raynal
2023-02-12 20:15           ` Alexander Aring
2023-02-13 10:15             ` Miquel Raynal
2023-02-14 13:51               ` Alexander Aring
2023-02-14 14:28                 ` Miquel Raynal
2023-02-17  4:46                   ` Alexander Aring
2023-02-17  8:52                     ` Miquel Raynal
2023-02-21  2:54                       ` Alexander Aring
2023-02-21  3:05                         ` Alexander Aring
2023-02-24 13:57                         ` Miquel Raynal
2022-11-29 16:00 ` [PATCH wpan-next 2/6] ieee802154: Define a beacon frame header Miquel Raynal
2022-11-29 16:00 ` [PATCH wpan-next 3/6] ieee802154: Introduce a helper to validate a channel Miquel Raynal
2022-11-29 16:00 ` [PATCH wpan-next 4/6] mac802154: Prepare forcing specific symbol duration Miquel Raynal
2022-11-29 16:00 ` [PATCH wpan-next 5/6] mac802154: Add MLME Tx locked helpers Miquel Raynal
2022-11-29 16:00 ` [PATCH wpan-next 6/6] mac802154: Handle passive scanning Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230210234722.4cf0934f@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=david.girault@qorvo.com \
    --cc=edumazet@google.com \
    --cc=frederic.blain@qorvo.com \
    --cc=guilhem.imberton@qorvo.com \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico@ni.fr.eu.org \
    --cc=pabeni@redhat.com \
    --cc=romuald.despres@qorvo.com \
    --cc=stefan@datenfreihafen.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).