From: Steen Hegelund <steen.hegelund@microchip.com>
To: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Steen Hegelund <steen.hegelund@microchip.com>,
<UNGLinuxDriver@microchip.com>,
Randy Dunlap <rdunlap@infradead.org>,
"Casper Andersson" <casper.casan@gmail.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Wan Jiabing <wanjiabing@vivo.com>,
"Nathan Huckleberry" <nhuck@google.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"Steen Hegelund" <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Dan Carpenter <error27@gmail.com>,
Michael Walle <michael@walle.cc>
Subject: [PATCH net-next 03/10] net: microchip: sparx5: Egress VLAN TPID configuration follows IFH
Date: Mon, 13 Feb 2023 10:24:19 +0100 [thread overview]
Message-ID: <20230213092426.1331379-4-steen.hegelund@microchip.com> (raw)
In-Reply-To: <20230213092426.1331379-1-steen.hegelund@microchip.com>
This changes the TPID of the egress frames to use the TPID stored in the
IFH (internal frame header), which ensures that this is the TPID classified
for the frame at ingress.
Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
---
drivers/net/ethernet/microchip/sparx5/sparx5_vlan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_vlan.c b/drivers/net/ethernet/microchip/sparx5/sparx5_vlan.c
index 34f954bbf815..ac001ae59a38 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_vlan.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_vlan.c
@@ -219,8 +219,8 @@ void sparx5_vlan_port_apply(struct sparx5 *sparx5,
spx5_wr(val, sparx5,
ANA_CL_VLAN_FILTER_CTRL(port->portno, 0));
- /* Egress configuration (REW_TAG_CFG): VLAN tag type to 8021Q */
- val = REW_TAG_CTRL_TAG_TPID_CFG_SET(0);
+ /* Egress configuration (REW_TAG_CFG): VLAN tag selected via IFH */
+ val = REW_TAG_CTRL_TAG_TPID_CFG_SET(5);
if (port->vlan_aware) {
if (port->vid)
/* Tag all frames except when VID == DEFAULT_VLAN */
--
2.39.1
next prev parent reply other threads:[~2023-02-13 9:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 9:24 [PATCH net-next 00/10] Adding Sparx5 ES0 VCAP support Steen Hegelund
2023-02-13 9:24 ` [PATCH net-next 01/10] net: microchip: sparx5: Discard frames with SMAC multicast addresses Steen Hegelund
2023-02-13 9:24 ` [PATCH net-next 02/10] net: microchip: sparx5: Clear rule counter even if lookup is disabled Steen Hegelund
2023-02-13 11:29 ` Dan Carpenter
2023-02-13 12:44 ` Steen Hegelund
2023-02-13 15:06 ` Dan Carpenter
2023-02-13 15:32 ` Steen Hegelund
2023-02-13 15:38 ` Dan Carpenter
2023-02-13 9:24 ` Steen Hegelund [this message]
2023-02-13 9:24 ` [PATCH net-next 04/10] net: microchip: sparx5: Use chain ids without offsets when enabling rules Steen Hegelund
2023-02-13 11:05 ` Dan Carpenter
2023-02-13 12:48 ` Steen Hegelund
2023-02-13 15:07 ` Dan Carpenter
2023-02-13 15:13 ` Dan Carpenter
2023-02-13 15:46 ` Steen Hegelund
2023-02-13 9:24 ` [PATCH net-next 05/10] net: microchip: sparx5: Improve the error handling for linked rules Steen Hegelund
2023-02-13 9:24 ` [PATCH net-next 06/10] net: microchip: sparx5: Add ES0 VCAP model and updated KUNIT VCAP model Steen Hegelund
2023-02-13 9:24 ` [PATCH net-next 07/10] net: microchip: sparx5: Updated register interface with VCAP ES0 access Steen Hegelund
2023-02-13 9:24 ` [PATCH net-next 08/10] net: microchip: sparx5: Add ES0 VCAP keyset configuration for Sparx5 Steen Hegelund
2023-02-13 9:24 ` [PATCH net-next 09/10] net: microchip: sparx5: Add TC support for the ES0 VCAP Steen Hegelund
2023-02-13 9:24 ` [PATCH net-next 10/10] net: microchip: sparx5: Add TC vlan action " Steen Hegelund
2023-02-13 11:03 ` Dan Carpenter
2023-02-13 12:50 ` Steen Hegelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213092426.1331379-4-steen.hegelund@microchip.com \
--to=steen.hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=casper.casan@gmail.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=nhuck@google.com \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).