* [PATCH bpf-next] ice: update xdp_features with xdp multi-buff
@ 2023-02-09 11:17 Lorenzo Bianconi
2023-02-14 1:23 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Bianconi @ 2023-02-09 11:17 UTC (permalink / raw)
To: bpf
Cc: netdev, ast, daniel, andrii, edumazet, kuba, pabeni, davem,
jesse.brandeburg, anthony.l.nguyen, intel-wired-lan,
lorenzo.bianconi
Now ice driver supports xdp multi-buffer so add it to xdp_features.
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
drivers/net/ethernet/intel/ice/ice_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 074b0e6d0e2d..7194888d2a3d 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -2913,7 +2913,7 @@ ice_xdp_setup_prog(struct ice_vsi *vsi, struct bpf_prog *prog,
if (xdp_ring_err)
NL_SET_ERR_MSG_MOD(extack, "Setting up XDP Tx resources failed");
}
- xdp_features_set_redirect_target(vsi->netdev, false);
+ xdp_features_set_redirect_target(vsi->netdev, true);
/* reallocate Rx queues that are used for zero-copy */
xdp_ring_err = ice_realloc_zc_buf(vsi, true);
if (xdp_ring_err)
@@ -3463,7 +3463,8 @@ static int ice_cfg_netdev(struct ice_vsi *vsi)
ice_set_netdev_features(netdev);
netdev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
- NETDEV_XDP_ACT_XSK_ZEROCOPY;
+ NETDEV_XDP_ACT_XSK_ZEROCOPY |
+ NETDEV_XDP_ACT_RX_SG;
ice_set_ops(netdev);
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] ice: update xdp_features with xdp multi-buff
2023-02-09 11:17 [PATCH bpf-next] ice: update xdp_features with xdp multi-buff Lorenzo Bianconi
@ 2023-02-14 1:23 ` Jakub Kicinski
2023-02-14 1:39 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-02-14 1:23 UTC (permalink / raw)
To: Lorenzo Bianconi, anthony.l.nguyen
Cc: bpf, netdev, ast, daniel, andrii, edumazet, pabeni, davem,
jesse.brandeburg, intel-wired-lan, lorenzo.bianconi
On Thu, 9 Feb 2023 12:17:25 +0100 Lorenzo Bianconi wrote:
> Now ice driver supports xdp multi-buffer so add it to xdp_features.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Let me take this one in directly the same as the other xdp_feature
follow ups.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bpf-next] ice: update xdp_features with xdp multi-buff
2023-02-14 1:23 ` Jakub Kicinski
@ 2023-02-14 1:39 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-02-14 1:39 UTC (permalink / raw)
To: Lorenzo Bianconi, anthony.l.nguyen
Cc: bpf, netdev, ast, daniel, andrii, edumazet, pabeni, davem,
jesse.brandeburg, intel-wired-lan, lorenzo.bianconi
On Mon, 13 Feb 2023 17:23:58 -0800 Jakub Kicinski wrote:
> On Thu, 9 Feb 2023 12:17:25 +0100 Lorenzo Bianconi wrote:
> > Now ice driver supports xdp multi-buffer so add it to xdp_features.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> Let me take this one in directly the same as the other xdp_feature
> follow ups.
Ah, this one is where we had a conflict in the bpf-next PR.
You'll need to rebase.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-14 1:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-09 11:17 [PATCH bpf-next] ice: update xdp_features with xdp multi-buff Lorenzo Bianconi
2023-02-14 1:23 ` Jakub Kicinski
2023-02-14 1:39 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).