From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, jacob.e.keller@intel.com, moshe@nvidia.com,
simon.horman@corigine.com
Subject: Re: [patch net-next v2] devlink: don't allow to change net namespace for FW_ACTIVATE reload action
Date: Mon, 13 Feb 2023 22:13:11 -0800 [thread overview]
Message-ID: <20230213221311.43d98ba8@kernel.org> (raw)
In-Reply-To: <20230213115836.3404039-1-jiri@resnulli.us>
On Mon, 13 Feb 2023 12:58:36 +0100 Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> The change on network namespace only makes sense during re-init reload
> action. For FW activation it is not applicable. So check if user passed
> an ATTR indicating network namespace change request and forbid it.
>
> Fixes: ccdf07219da6 ("devlink: Add reload action option to devlink reload command")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
The fixes tag needs to go, too, in that case. Otherwise stable will
likely suck it in. Which is riskier than putting it into an -rc.
No need to repost tho, we can drop the tag when applying.
Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2023-02-14 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 11:58 [patch net-next v2] devlink: don't allow to change net namespace for FW_ACTIVATE reload action Jiri Pirko
2023-02-14 6:13 ` Jakub Kicinski [this message]
2023-02-14 7:31 ` Jiri Pirko
2023-02-14 14:30 ` patchwork-bot+netdevbpf
2023-02-20 9:01 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213221311.43d98ba8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).