From: Jakub Kicinski <kuba@kernel.org>
To: Moshe Shemesh <moshe@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@nvidia.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 01/10] devlink: Split out health reporter create code
Date: Mon, 13 Feb 2023 22:17:12 -0800 [thread overview]
Message-ID: <20230213221712.3f91f288@kernel.org> (raw)
In-Reply-To: <1676294058-136786-2-git-send-email-moshe@nvidia.com>
On Mon, 13 Feb 2023 15:14:09 +0200 Moshe Shemesh wrote:
> +/**
> + * devl_port_health_reporter_create - create devlink health reporter for
> + * specified port instance
> + *
> + * @port: devlink_port which should contain the new reporter
> + * @ops: ops
> + * @graceful_period: to avoid recovery loops, in msecs
> + * @priv: priv
> + */
Can we drop or touch-up the kdoc as we move?
The indent should just use a space, not a tab.
() after function name
@port: devlink_port to which the health reports will relate
@ops: driver health reporter ops
@graceful_period: min time between recovery attempts
@priv: driver priv pointer
next prev parent reply other threads:[~2023-02-14 6:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 13:14 [PATCH net-next 00/10] devlink: cleanups and move devlink health functionality to separate file Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 01/10] devlink: Split out health reporter create code Moshe Shemesh
2023-02-14 6:17 ` Jakub Kicinski [this message]
2023-02-14 13:18 ` Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 02/10] devlink: health: Fix nla_nest_end in error flow Moshe Shemesh
2023-02-14 6:18 ` Jakub Kicinski
2023-02-14 13:21 ` Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 03/10] devlink: Move devlink health get and set code to health file Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 04/10] devlink: health: Don't try to add trace with NULL msg Moshe Shemesh
2023-02-14 6:22 ` Jakub Kicinski
2023-02-14 13:48 ` Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 05/10] devlink: Move devlink health report and recover to health file Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 06/10] devlink: Move devlink fmsg and health diagnose " Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 07/10] devlink: Move devlink health dump " Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 08/10] devlink: Move devlink health test " Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 09/10] devlink: Move health common function " Moshe Shemesh
2023-02-13 13:14 ` [PATCH net-next 10/10] devlink: Update devlink health documentation Moshe Shemesh
2023-02-13 13:35 ` [PATCH net-next 00/10] devlink: cleanups and move devlink health functionality to separate file Jiri Pirko
2023-02-14 6:23 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213221712.3f91f288@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).