From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org, xiyou.wangcong@gmail.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
stephen@networkplumber.org, dsahern@gmail.com
Subject: Re: [PATCH net-next 0/5] net/sched: Retire some tc qdiscs and classifiers
Date: Tue, 14 Feb 2023 13:40:13 -0800 [thread overview]
Message-ID: <20230214134013.0ad390dd@kernel.org> (raw)
In-Reply-To: <Y+uZ5LLX8HugO/5+@nanopsycho>
On Tue, 14 Feb 2023 15:25:40 +0100 Jiri Pirko wrote:
> Tue, Feb 14, 2023 at 02:49:10PM CET, jhs@mojatatu.com wrote:
> >The CBQ + dsmark qdiscs and the tcindex + rsvp classifiers have served us for
> >over 2 decades. Unfortunately, they have not been getting much attention due
> >to reduced usage. While we dont have a good metric for tabulating how much use
> >a specific kernel feature gets, for these specific features we observed that
> >some of the functionality has been broken for some time and no users complained.
> >In addition, syzkaller has been going to town on most of these and finding
> >issues; and while we have been fixing those issues, at times it becomes obvious
> >that we would need to perform bigger surgeries to resolve things found while
> >getting a syzkaller fix in place. After some discussion we feel that in order
> >to reduce the maintenance burden it is best to retire them.
> >
> >This patchset leaves the UAPI alone. I could send another version which deletes
> >the UAPI as well. AFAIK, this has not been done before - so it wasnt clear what
> >how to handle UAPI. It seems legit to just delete it but we would need to
> >coordinate with iproute2 (given they sync up with kernel uapi headers). There
>
> I think we have to let the UAPI there to rot in order not to break
> compilation of apps that use those (no relation to iproute2).
Yeah, I was hoping there's no other users but this is the first match
on GitHub:
https://github.com/t2mune/nield/blob/0c0848d1d1e6c006185465ee96aeb5a13a1589e6/src/tcmsg_qdisc_dsmark.c
:(
next prev parent reply other threads:[~2023-02-14 21:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 13:49 [PATCH net-next 0/5] net/sched: Retire some tc qdiscs and classifiers Jamal Hadi Salim
2023-02-14 13:49 ` [PATCH net-next 1/5] net/sched: Retire CBQ qdisc Jamal Hadi Salim
2023-02-14 13:49 ` [PATCH net-next 2/5] net/sched: Retire ATM qdisc Jamal Hadi Salim
2023-02-14 13:49 ` [PATCH net-next 3/5] net/sched: Retire dsmark qdisc Jamal Hadi Salim
2023-02-14 13:49 ` [PATCH net-next 4/5] net/sched: Retire tcindex classifier Jamal Hadi Salim
2023-02-14 13:49 ` [PATCH net-next 5/5] net/sched: Retire rsvp classifier Jamal Hadi Salim
2023-02-14 14:01 ` iproute2/user space code obsoletion when depending on kernel features WAS([PATCH net-next 0/5] net/sched: Retire some tc qdiscs and classifiers) Jamal Hadi Salim
2023-02-14 14:25 ` [PATCH net-next 0/5] net/sched: Retire some tc qdiscs and classifiers Jiri Pirko
2023-02-14 21:40 ` Jakub Kicinski [this message]
2023-02-14 21:41 ` Jakub Kicinski
2023-02-14 23:05 ` Jamal Hadi Salim
2023-02-14 23:22 ` Jakub Kicinski
2023-02-14 23:52 ` Jamal Hadi Salim
2023-02-15 0:41 ` Jakub Kicinski
2023-02-15 7:50 ` Jiri Pirko
2023-02-15 13:42 ` Pedro Tammela
2023-02-15 16:37 ` Jamal Hadi Salim
2023-02-16 8:51 ` Paolo Abeni
2023-02-16 9:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214134013.0ad390dd@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).