From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC4BC64ED6 for ; Tue, 14 Feb 2023 14:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231899AbjBNOGI (ORCPT ); Tue, 14 Feb 2023 09:06:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231608AbjBNOGH (ORCPT ); Tue, 14 Feb 2023 09:06:07 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8CB69EC5; Tue, 14 Feb 2023 06:06:05 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 4B42960008; Tue, 14 Feb 2023 14:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1676383564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EiPPK/ws3wnJ831C31CfYEtnJbbFmvzW70yxtxUG7rI=; b=fkWqTiSWzbfN/QwT1GO74MVuBocrUqDD5tkktQ0WkswOerYpznVL+qO5muaa5usvPNimAG fO4YYPlGVVM6eI8BfOGSsIcoZkyoIknWT1gwUKzVIHYIUUBREXoooaOWHYnJejdKVr+WkQ wtNkeoWXhF6gZVzWTR3HQtzo/iAwBw3FY2ue+Yg6hsv9+Kn+6CV7PKcW2FgSKbhbF3Bxab gDrN87bEWCoqzXa8Dii1MzTF2zIomxDeL0PHYNEvWSlcpJ87tdP/S+8d/FMaf9XSYl6TlC qeRTQk/jbyGn+Ne+G8pL6y6coyn5BTsxc2Jv5gfO6CwNJX06a9oclimRBc+e1Q== Date: Tue, 14 Feb 2023 15:06:00 +0100 From: Miquel Raynal To: Alexander Aring Cc: Alexander Aring , Stefan Schmidt , linux-wpan@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Guilhem Imberton , Thomas Petazzoni Subject: Re: [PATCH wpan-next 1/6] ieee802154: Add support for user scanning requests Message-ID: <20230214150600.1c21066b@xps-13> In-Reply-To: References: <20221129160046.538864-1-miquel.raynal@bootlin.com> <20221129160046.538864-2-miquel.raynal@bootlin.com> <20230206101235.0371da87@xps-13> <20230213183535.05e62c1c@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Alexander, aahringo@redhat.com wrote on Tue, 14 Feb 2023 08:53:57 -0500: > Hi, >=20 > On Tue, Feb 14, 2023 at 8:34 AM Alexander Aring wro= te: > > > > Hi, > > > > On Mon, Feb 13, 2023 at 12:35 PM Miquel Raynal > > wrote: =20 > > > > > > Hi Alexander, > > > =20 > > > > > > > > +static int nl802154_trigger_scan(struct sk_buff *skb, stru= ct genl_info *info) > > > > > > > > +{ > > > > > > > > + struct cfg802154_registered_device *rdev =3D info->= user_ptr[0]; > > > > > > > > + struct net_device *dev =3D info->user_ptr[1]; > > > > > > > > + struct wpan_dev *wpan_dev =3D dev->ieee802154_ptr; > > > > > > > > + struct wpan_phy *wpan_phy =3D &rdev->wpan_phy; > > > > > > > > + struct cfg802154_scan_request *request; > > > > > > > > + u8 type; > > > > > > > > + int err; > > > > > > > > + > > > > > > > > + /* Monitors are not allowed to perform scans */ > > > > > > > > + if (wpan_dev->iftype =3D=3D NL802154_IFTYPE_MONITOR) > > > > > > > > + return -EPERM; =20 > > > > > > > > > > > > > > btw: why are monitors not allowed? =20 > > > > > > > > > > > > I guess I had the "active scan" use case in mind which of cours= e does > > > > > > not work with monitors. Maybe I can relax this a little bit ind= eed, > > > > > > right now I don't remember why I strongly refused scans on moni= tors. =20 > > > > > > > > > > Isn't it that scans really work close to phy level? Means in this= case > > > > > we disable mostly everything of MAC filtering on the transceiver = side. > > > > > Then I don't see any reasons why even monitors can't do anything,= they > > > > > also can send something. But they really don't have any specific > > > > > source address set, so long addresses are none for source address= es, I > > > > > don't see any problem here. They also don't have AACK handling, b= ut > > > > > it's not required for scan anyway... > > > > > > > > > > If this gets too complicated right now, then I am also fine with > > > > > returning an error here, we can enable it later but would it be b= etter > > > > > to use ENOTSUPP or something like that in this case? EPERM sounds= like > > > > > you can do that, but you don't have the permissions. > > > > > =20 > > > > > > > > For me a scan should also be possible from iwpan phy $PHY scan (or > > > > whatever the scan command is, or just enable beacon)... to go over = the > > > > dev is just a shortcut for "I mean whatever the phy is under this d= ev" > > > > ? =20 > > > > > > Actually only coordinators (in a specific state) should be able to se= nd > > > beacons, so I am kind of against allowing that shortcut, because there > > > are usually two dev interfaces on top of the phy's, a regular "NODE" > > > and a "COORD", so I don't think we should go that way. > > > > > > For scans however it makes sense, I've added the necessary changes in > > > wpan-tools. The TOP_LEVEL(scan) macro however does not support using > > > the same command name twice because it creates a macro, so this one > > > only supports a device name (the interface command has kind of the sa= me > > > situation and uses a HIDDEN() macro which cannot be used here). > > > =20 > > > > Yes, I was thinking about scanning only. > > =20 > > > So in summary here is what is supported: > > > - dev beacon > > > - dev scan trigger|abort > > > - phy scan trigger|abort > > > - dev scan (the blocking one, which triggers, listens and retur= ns) > > > > > > Do you agree? > > > =20 > > > > Okay, yes. I trust you. =20 >=20 > btw: at the point when a scan requires a source address... it cannot > be done because then a scan is related to a MAC instance -> an wpan > interface and we need to bind to it. But I think it doesn't? I'm not sure I follow you here. You mean in case of active scan? The operation is always tight to a device in the end, even if you provide a phy in userspace. So I guess it's not a problem. Or maybe I didn't get the question right? Thanks, Miqu=C3=A8l