From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, <jiri@nvidia.com>, <idosch@idosch.org>
Subject: Re: [PATCH net-next 0/5][pull request] add v2 FW logging for ice driver
Date: Tue, 14 Feb 2023 18:07:12 -0800 [thread overview]
Message-ID: <20230214180712.53fc8ba2@kernel.org> (raw)
In-Reply-To: <ac41759b-29d1-acfd-7165-96bbac1840c7@intel.com>
On Tue, 14 Feb 2023 17:33:25 -0800 Jacob Keller wrote:
> > Yes, I know, all NICs are generic IO devices now. While the only
> > example of what can go wrong we heard so far is a link flap...
> >
> > Reimplementing a similar API in devlink with a backward compat
> > is definitely an option.
>
> Sure. Well the interface is more of a way for firmware team to get
> debugging information out of the firmware. Its sort of like a "print"
> debugging, where information about the state of firmware during
> different activities can be recorded.
>
> The idea is that when a problem is detected by a user, they can enable
> firmware logging to capture this data and then that can aid us in
> determining what really went wrong.
>
> It isn't a "we detected a problem" interface. It's a "here's a bunch of
> debugging logging you asked for!" interface.
Yes, none of this sounds very usable in production. So maybe just put
the basic interface in debugfs and keep the per-module etc. whetevers
in the out of tree driver? That seems like a level of granularity
useful for development.
prev parent reply other threads:[~2023-02-15 2:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 19:06 [PATCH net-next 0/5][pull request] add v2 FW logging for ice driver Tony Nguyen
2023-02-09 19:06 ` [PATCH net-next 1/5] ice: remove FW logging code Tony Nguyen
2023-02-09 19:06 ` [PATCH net-next 2/5] ice: enable devlink to check FW logging status Tony Nguyen
2023-02-09 19:07 ` [PATCH net-next 3/5] ice: add ability to query/set FW log level and resolution Tony Nguyen
2023-02-09 19:07 ` [PATCH net-next 4/5] ice: disable FW logging on driver unload Tony Nguyen
2023-02-09 19:07 ` [PATCH net-next 5/5] ice: use debugfs to output FW log data Tony Nguyen
2023-02-11 4:23 ` [PATCH net-next 0/5][pull request] add v2 FW logging for ice driver Jakub Kicinski
2023-02-13 23:46 ` Paul M Stillwell Jr
2023-02-14 0:40 ` Jakub Kicinski
2023-02-14 16:14 ` Paul M Stillwell Jr
2023-02-14 20:44 ` Jakub Kicinski
2023-02-14 22:39 ` Jacob Keller
2023-02-14 23:19 ` Jakub Kicinski
2023-02-15 0:07 ` Jacob Keller
2023-02-15 1:16 ` Jakub Kicinski
2023-02-15 1:33 ` Jacob Keller
2023-02-15 2:07 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214180712.53fc8ba2@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).