From: Jakub Kicinski <kuba@kernel.org>
To: Deepak R Varma <drv@mailo.com>
Cc: Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH v2] octeontx2-pf: Use correct struct reference in test condition
Date: Tue, 14 Feb 2023 20:28:41 -0800 [thread overview]
Message-ID: <20230214202841.595656be@kernel.org> (raw)
In-Reply-To: <Y+ohwh7K5CYHhziq@ubun2204.myguest.virtualbox.org>
On Mon, 13 Feb 2023 17:10:50 +0530 Deepak R Varma wrote:
> Fix the typo/copy-paste error by replacing struct variable ah_esp_mask name
> by ah_esp_hdr.
> Issue identified using doublebitand.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
Your patch did not make it to the list, please make sure or recipients
are correct (common error is to lack a space between name and the
address, e.g. "David S. Miller"<davem@davemloft.net>).
When reposting please add a Fixes tag.
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> index 684cb8ec9f21..10e11262d48a 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> @@ -793,7 +793,7 @@ static int otx2_prepare_ipv6_flow(struct ethtool_rx_flow_spec *fsp,
>
> /* NPC profile doesn't extract AH/ESP header fields */
> if ((ah_esp_mask->spi & ah_esp_hdr->spi) ||
> - (ah_esp_mask->tclass & ah_esp_mask->tclass))
> + (ah_esp_mask->tclass & ah_esp_hdr->tclass))
> return -EOPNOTSUPP;
>
> if (flow_type == AH_V6_FLOW)
next parent reply other threads:[~2023-02-15 4:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Y+ohwh7K5CYHhziq@ubun2204.myguest.virtualbox.org>
2023-02-15 4:28 ` Jakub Kicinski [this message]
2023-02-17 7:55 ` [PATCH v2] octeontx2-pf: Use correct struct reference in test condition Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214202841.595656be@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=drv@mailo.com \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).