From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC943C636D7 for ; Wed, 15 Feb 2023 17:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230092AbjBORfM (ORCPT ); Wed, 15 Feb 2023 12:35:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229805AbjBORfL (ORCPT ); Wed, 15 Feb 2023 12:35:11 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD3933A84F for ; Wed, 15 Feb 2023 09:35:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 13446CE2331 for ; Wed, 15 Feb 2023 17:35:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9461DC433D2; Wed, 15 Feb 2023 17:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676482507; bh=enNaZd9AgStIojhoFtdmMESry47u3a45OS5N9q1nlE8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LjpAkbT0rnHnPZTdOngtamOanMUNayDx1nQj5l8qSbAixN0NGUbyNSZ0+6DYv/Lx7 RvPbzgt254s1iY1lKQCS1IliWKLirvjvFv7YFQpt1uBp3r/GqaF1KRTKg0A6rrwipR sesCjnI6kvqKFQlcX2wYXe7nVQ3uxOxTqHCO9X3Qz5OHoWYi6zWcXPYdZ4QcbWvty8 BzRND89nLQUWe8nyF0Kjt5iUFcQsWwtH7XnnHuYGenzX9+06/L4CnNdhnFZ5e+2go5 xwsrXajpEo/cfZNVigMwzF73nZDEEfCP6FCju+cqENDZKsgO0uvEumt1aJP2hfeE8F kMm26d0VFenug== Date: Wed, 15 Feb 2023 09:35:05 -0800 From: Jakub Kicinski To: Jamal Hadi Salim Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, willemb@google.com, fw@strlen.de, saeedm@nvidia.com, leon@kernel.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, roid@nvidia.com, ozsh@nvidia.com, paulb@nvidia.com Subject: Re: [PATCH net-next 3/3] net: create and use NAPI version of tc_skb_ext_alloc() Message-ID: <20230215093505.4b27c8ea@kernel.org> In-Reply-To: References: <20230215034355.481925-1-kuba@kernel.org> <20230215034355.481925-4-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 15 Feb 2023 11:50:55 -0500 Jamal Hadi Salim wrote: > Dumb question: Would this work with a consumer of the metadata past > RPS stage? didnt look closely but assumed per cpu skb_ext because of > the napi context - which will require a per cpu pointer to fetch it > later. The cache is just for allocation, specifically for the case where driver allocates the skb and it's quickly coalesced by GRO. The lifetime of the allocated object is not changed.