From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, willemb@google.com
Subject: Re: [RFC] net: skbuff: let struct skb_ext live inside the head
Date: Wed, 15 Feb 2023 10:13:56 -0800 [thread overview]
Message-ID: <20230215101356.3b86c451@kernel.org> (raw)
In-Reply-To: <20230215094332.GB9908@breakpoint.cc>
On Wed, 15 Feb 2023 10:43:32 +0100 Florian Westphal wrote:
> I think the cleaner solution would be to move the new extension ids
> into sk_buff itself (at the end, uninitialized data unless used).
>
> Those extensions would always reside there and not in the slab object.
Do you mean the entire extension? 8B of metadata + (possibly) 32B
of the key?
> Obviously that only makes sense for extensions where we assume
> that typical workload will require them, which might be a hard call to
> make.
I'm guessing that's the reason why Google is okay with putting the key
in the skb - they know they will use it most of the time. But an
average RHEL user may appreciate the skb growth for an esoteric protocol
to a much smaller extent :(
next prev parent reply other threads:[~2023-02-15 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 3:44 [RFC] net: skbuff: let struct skb_ext live inside the head Jakub Kicinski
2023-02-15 8:53 ` Paolo Abeni
2023-02-15 17:58 ` Jakub Kicinski
2023-02-15 9:43 ` Florian Westphal
2023-02-15 14:37 ` Willem de Bruijn
2023-02-15 18:10 ` Jakub Kicinski
2023-02-15 18:13 ` Jakub Kicinski [this message]
2023-02-16 13:28 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215101356.3b86c451@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).