* [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset
@ 2023-02-14 8:42 Horatiu Vultur
2023-02-16 5:30 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Horatiu Vultur @ 2023-02-14 8:42 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: davem, edumazet, kuba, pabeni, UNGLinuxDriver, Horatiu Vultur
Now the VCAP API automatically selects the action set, therefore is
not needed to be hardcoded anymore to hardcode the action in the
lan966x. Therefore remove this.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
index bd10a71897418..f960727ecaeec 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
@@ -261,8 +261,6 @@ static int lan966x_tc_flower_add(struct lan966x_port *port,
0);
err |= vcap_rule_add_action_u32(vrule, VCAP_AF_MASK_MODE,
LAN966X_PMM_REPLACE);
- err |= vcap_set_rule_set_actionset(vrule,
- VCAP_AFS_BASE_TYPE);
if (err)
goto out;
--
2.38.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset
2023-02-14 8:42 [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset Horatiu Vultur
@ 2023-02-16 5:30 ` Jakub Kicinski
2023-02-16 10:37 ` Horatiu Vultur
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-02-16 5:30 UTC (permalink / raw)
To: Horatiu Vultur
Cc: netdev, linux-kernel, davem, edumazet, pabeni, UNGLinuxDriver
On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote:
> Now the VCAP API automatically selects the action set, therefore is
> not needed to be hardcoded anymore to hardcode the action in the
> lan966x. Therefore remove this.
The commit message needs some attention here.
While at it - instead of saying "now" could you provide the commit
reference? E.g. "Since commit $hash ("$title") the VCAP API...".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset
2023-02-16 5:30 ` Jakub Kicinski
@ 2023-02-16 10:37 ` Horatiu Vultur
0 siblings, 0 replies; 3+ messages in thread
From: Horatiu Vultur @ 2023-02-16 10:37 UTC (permalink / raw)
To: Jakub Kicinski
Cc: netdev, linux-kernel, davem, edumazet, pabeni, UNGLinuxDriver
The 02/15/2023 21:30, Jakub Kicinski wrote:
Hi Jakub,
>
> On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote:
> > Now the VCAP API automatically selects the action set, therefore is
> > not needed to be hardcoded anymore to hardcode the action in the
> > lan966x. Therefore remove this.
>
> The commit message needs some attention here.
> While at it - instead of saying "now" could you provide the commit
> reference? E.g. "Since commit $hash ("$title") the VCAP API...".
I will update this in the next version. Thanks for the feedback!
--
/Horatiu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-16 10:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-14 8:42 [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset Horatiu Vultur
2023-02-16 5:30 ` Jakub Kicinski
2023-02-16 10:37 ` Horatiu Vultur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).