* [Patch] [drivers/net] Remove unneeded version.h includes
@ 2023-02-16 0:48 Jesper Juhl
2023-02-16 6:06 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Juhl @ 2023-02-16 0:48 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, David S. Miller
From bb51298e935ded65d79cb0d489d38f867a22a092 Mon Sep 17 00:00:00 2001
From: Jesper Juhl <jesperjuhl76@gmail.com>
Date: Mon, 13 Feb 2023 02:46:58 +0100
Subject: [PATCH 02/12] [drivers/net] Remove unneeded version.h includes
pointed out by 'make versioncheck'
Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>
---
drivers/net/ethernet/qlogic/qede/qede.h | 1 -
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
index f90dcfe9ee68..6ff1bd48d2aa 100644
--- a/drivers/net/ethernet/qlogic/qede/qede.h
+++ b/drivers/net/ethernet/qlogic/qede/qede.h
@@ -7,7 +7,6 @@
#ifndef _QEDE_H_
#define _QEDE_H_
#include <linux/compiler.h>
-#include <linux/version.h>
#include <linux/workqueue.h>
#include <linux/netdevice.h>
#include <linux/interrupt.h>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 8034d812d5a0..374a86b875a3 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -4,7 +4,6 @@
* Copyright (c) 2019-2020 Marvell International Ltd.
*/
-#include <linux/version.h>
#include <linux/types.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] [drivers/net] Remove unneeded version.h includes
2023-02-16 0:48 [Patch] [drivers/net] Remove unneeded version.h includes Jesper Juhl
@ 2023-02-16 6:06 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2023-02-16 6:06 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-kernel, netdev, David S. Miller
On Thu, 16 Feb 2023 01:48:50 +0100 (CET) Jesper Juhl wrote:
> From: Jesper Juhl <jesperjuhl76@gmail.com>
> To: linux-kernel@vger.kernel.org
> cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
> Subject: [Patch] [drivers/net] Remove unneeded version.h includes
> Date: Thu, 16 Feb 2023 01:48:50 +0100 (CET)
> User-Agent: Alpine 2.26 (LNX 649 2022-06-02)
>
> From bb51298e935ded65d79cb0d489d38f867a22a092 Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <jesperjuhl76@gmail.com>
> Date: Mon, 13 Feb 2023 02:46:58 +0100
> Subject: [PATCH 02/12] [drivers/net] Remove unneeded version.h includes
> pointed out by 'make versioncheck'
You have the headers twice and no commit message.
Maybe try git send-email?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-16 6:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16 0:48 [Patch] [drivers/net] Remove unneeded version.h includes Jesper Juhl
2023-02-16 6:06 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).