From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset
Date: Thu, 16 Feb 2023 11:37:03 +0100 [thread overview]
Message-ID: <20230216103703.vutn5bba3ovtpiei@soft-dev3-1> (raw)
In-Reply-To: <20230215213052.6ecea372@kernel.org>
The 02/15/2023 21:30, Jakub Kicinski wrote:
Hi Jakub,
>
> On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote:
> > Now the VCAP API automatically selects the action set, therefore is
> > not needed to be hardcoded anymore to hardcode the action in the
> > lan966x. Therefore remove this.
>
> The commit message needs some attention here.
> While at it - instead of saying "now" could you provide the commit
> reference? E.g. "Since commit $hash ("$title") the VCAP API...".
I will update this in the next version. Thanks for the feedback!
--
/Horatiu
prev parent reply other threads:[~2023-02-16 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 8:42 [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule actionset Horatiu Vultur
2023-02-16 5:30 ` Jakub Kicinski
2023-02-16 10:37 ` Horatiu Vultur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216103703.vutn5bba3ovtpiei@soft-dev3-1 \
--to=horatiu.vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox