Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Ferenc Fejes <fejes@inf.elte.hu>
Cc: peti.antal99@gmail.com, "andrew@lunn.ch" <andrew@lunn.ch>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
	"vinicius.gomes@intel.com" <vinicius.gomes@intel.com>,
	"shuah@kernel.org" <shuah@kernel.org>,
	"bigeasy@linutronix.de" <bigeasy@linutronix.de>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Yannick Vignon <yannick.vignon@nxp.com>,
	Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
	"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"richardcochran@gmail.com" <richardcochran@gmail.com>,
	"idosch@nvidia.com" <idosch@nvidia.com>,
	"gerhard@engleder-embedded.com" <gerhard@engleder-embedded.com>,
	"Y.B. Lu" <yangbo.lu@nxp.com>,
	"jiri@nvidia.com" <jiri@nvidia.com>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"kurt@linutronix.de" <kurt@linutronix.de>,
	Rui Sousa <rui.sousa@nxp.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>
Subject: Re: [PATCH v2 net-next] selftests: forwarding: add Per-Stream Filtering and Policing test for Ocelot
Date: Fri, 17 Feb 2023 15:07:39 +0200	[thread overview]
Message-ID: <20230217130739.flqby6ok3wh5mklw@skbuf> (raw)
In-Reply-To: <1284d04958725d772750d6e3908301c8f8a379c1.camel@inf.elte.hu>

Hi Ferenc,

On Fri, Feb 17, 2023 at 09:03:30AM +0100, Ferenc Fejes wrote:
> I agree, it takes time to guess what the intention behind the wording
> of the standard in some cases. I have the standard in front of me right
> now and its 2163 pages... Even if I grep to IPV, the context is
> overwhelmingly dense.
> 
(...)
> I'll try to ask around too, thanks for pointing this out. My best
> understanding from the IPV that the standard treat it as skb->priority.
> It defines IPV as a 32bit signed value, which clearly imply similar
> semantics as skb->priority, which can be much larger than the number of
> the queues or traffic classes.

What would you say if we made the software act_gate implementation
simply alter skb->priority, which would potentially affect more stuff
including the egress-qos-map of a VLAN device in the output path of the
skb? It would definitely put less pressure on the networking data
structures, at the price of leaving an exceedingly unlikely case
uncovered.

> Oh, alright. I continue to think about alternatives over introducing
> new members into sk_buff. It would be very nice to have proper act_gate
> IPV handling without hardware offload. Its great to see the support of
> frame preemption and PSFP support in more and more hardware but on the
> other hand it makes the lack of the proper software mode operation more
> and more awkward.

I'm not sure that cyclic queuing and forwarding done with software
forwarding is going to be that practical anyway?

  reply	other threads:[~2023-02-17 13:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-01 11:29 [PATCH v2 net-next] selftests: forwarding: add Per-Stream Filtering and Policing test for Ocelot Vladimir Oltean
2022-05-01 11:56 ` Kurt Kanzenbach
2022-05-02 23:10 ` patchwork-bot+netdevbpf
2022-05-06  7:49 ` Ferenc Fejes
2022-05-06 12:01   ` Vladimir Oltean
2022-05-06 12:24     ` Ferenc Fejes
2022-05-26  0:50       ` Vladimir Oltean
2022-05-26  6:40         ` Ferenc Fejes
2022-05-26  9:30           ` Vladimir Oltean
2023-02-16 13:47             ` Ferenc Fejes
2023-02-16 15:58               ` Vladimir Oltean
2023-02-17  8:03                 ` Ferenc Fejes
2023-02-17 13:07                   ` Vladimir Oltean [this message]
2023-02-17 14:35                     ` Ferenc Fejes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230217130739.flqby6ok3wh5mklw@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=bigeasy@linutronix.de \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=fejes@inf.elte.hu \
    --cc=gerhard@engleder-embedded.com \
    --cc=idosch@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peti.antal99@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=rui.sousa@nxp.com \
    --cc=shuah@kernel.org \
    --cc=vinicius.gomes@intel.com \
    --cc=vivien.didelot@gmail.com \
    --cc=xiaoliang.yang_1@nxp.com \
    --cc=yangbo.lu@nxp.com \
    --cc=yannick.vignon@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox