From: Vladimir Oltean <olteanv@gmail.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v2 net-next 0/5] add ethtool categorized statistics
Date: Fri, 17 Feb 2023 18:48:50 +0200 [thread overview]
Message-ID: <20230217164850.3jps62p2sfomee4r@skbuf> (raw)
In-Reply-To: <a0898de5-5990-4198-cda2-fe22679aec90@intel.com>
On Fri, Feb 17, 2023 at 03:54:48PM +0100, Alexander Lobakin wrote:
> From: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
> Date: Fri, 17 Feb 2023 16:32:06 +0530
>
> > [PATCH v2 net-next 0/5] add ethtool categorized statistics
>
> I'd like to see the cover letter's subject prefixed as well, e.g.
>
> [PATCH v2 net-next 0/5] net: dsa: microchip: add ethtool categorized
> statistics
>
> ...or so, depending on the usual prefix for ksz.
> Otherwise, it looks like you're adding something generic and only
> realize it targets a particular driver only after opening the thread itself.
+1
some people just look at the KSZ DSA driver all day, and so in their mind, it
then becomes implicit in the subject. But the cover letter description gets
turned by the netdev maintainers into a branch name for a merge commit, see:
fa15072b650a Merge branch 'sfc-devlink-support-for-ef100'
e9ab2559e2c5 Merge branch 'net-sched-transition-actions-to-pcpu-stats-and-rcu'
10d13421a6ae Merge branch 'net-core-commmon-prints-for-promisc'
a1d83abc8f2f Merge branch 'net-sched-retire-some-tc-qdiscs-and-classifiers'
and so, the naming of the cover letter has non-zero importance.
I agree that the contents of this patch set is absolutely disappointing
for someone reading the title and expecting some new ethtool counters.
prev parent reply other threads:[~2023-02-17 16:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 11:02 [PATCH v2 net-next 0/5] add ethtool categorized statistics Rakesh Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 1/5] net: dsa: microchip: add rmon grouping for ethtool statistics Rakesh Sankaranarayanan
2023-02-17 14:59 ` Alexander Lobakin
2023-02-21 4:37 ` Rakesh.Sankaranarayanan
2023-02-17 16:53 ` Vladimir Oltean
2023-02-17 17:40 ` Andrew Lunn
2023-02-21 4:40 ` Rakesh.Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 2/5] net: dsa: microchip: add eth ctrl " Rakesh Sankaranarayanan
2023-02-17 17:08 ` Vladimir Oltean
2023-02-21 7:14 ` Rakesh.Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac " Rakesh Sankaranarayanan
2023-02-17 15:01 ` Alexander Lobakin
2023-02-17 16:42 ` Vladimir Oltean
2023-02-24 16:07 ` Alexander Lobakin
2023-02-24 21:53 ` Vladimir Oltean
2023-02-27 14:31 ` Alexander Lobakin
2023-02-27 14:52 ` Andrew Lunn
2023-02-28 10:53 ` Alexander Lobakin
2023-02-17 11:02 ` [PATCH v2 net-next 4/5] net: dsa: microchip: add eth phy " Rakesh Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 5/5] net: dsa: microchip: remove num_alus_variable Rakesh Sankaranarayanan
2023-02-17 17:16 ` Vladimir Oltean
2023-02-21 7:25 ` Rakesh.Sankaranarayanan
2023-02-17 14:54 ` [PATCH v2 net-next 0/5] add ethtool categorized statistics Alexander Lobakin
2023-02-17 16:48 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217164850.3jps62p2sfomee4r@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rakesh.sankaranarayanan@microchip.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox