netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
	andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	Thangaraj Samynathan <Thangaraj.S@microchip.com>
Subject: Re: [PATCH v2 net-next 1/5] net: dsa: microchip: add rmon grouping for ethtool statistics
Date: Fri, 17 Feb 2023 18:53:46 +0200	[thread overview]
Message-ID: <20230217165346.2eaualia32kmliz6@skbuf> (raw)
In-Reply-To: <20230217110211.433505-2-rakesh.sankaranarayanan@microchip.com>

On Fri, Feb 17, 2023 at 04:32:07PM +0530, Rakesh Sankaranarayanan wrote:
>     Add support for ethtool standard device statistics grouping. Support rmon
>     statistics grouping using rmon groups parameter in ethtool command. rmon
>     provides packet size based range grouping. Common mib parameters are used
>     across all KSZ series swtches for packet size statistics, except for
>     KSZ8830. KSZ series have mib counters for packets with size:
>     - less than 64 Bytes,
>     - 65 to 127 Bytes,
>     - 128 to 255 Bytes,
>     - 256 to 511 Bytes,
>     - 512 to 1023 Bytes,
>     - 1024 to 1522 Bytes,
>     - 1523 to 2000 Bytes and
>     - More than 2001 Bytes
>     KSZ8830 have mib counters upto 1024-1522 range only. Since no other change,
>     common range used across all KSZ series, but used upto only upto 1024-1522
>     for KSZ8830.

Why are all commit messages indented in this way? Please keep the
default text indentation at 0 characters. I have never seen this style
in "git log".

> 
> Co-developed-by: Thangaraj Samynathan <Thangaraj.S@microchip.com>

Documentation/process/submitting-patches.rst:

Co-developed-by: states that the patch was co-created by multiple developers;
it is used to give attribution to co-authors (in addition to the author
attributed by the From: tag) when several people work on a single patch.  Since
Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
followed by a Signed-off-by: of the associated co-author.  Standard sign-off
procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the
chronological history of the patch insofar as possible, regardless of whether
the author is attributed via From: or Co-developed-by:.  Notably, the last
Signed-off-by: must always be that of the developer submitting the patch.

  parent reply	other threads:[~2023-02-17 16:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 11:02 [PATCH v2 net-next 0/5] add ethtool categorized statistics Rakesh Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 1/5] net: dsa: microchip: add rmon grouping for ethtool statistics Rakesh Sankaranarayanan
2023-02-17 14:59   ` Alexander Lobakin
2023-02-21  4:37     ` Rakesh.Sankaranarayanan
2023-02-17 16:53   ` Vladimir Oltean [this message]
2023-02-17 17:40     ` Andrew Lunn
2023-02-21  4:40     ` Rakesh.Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 2/5] net: dsa: microchip: add eth ctrl " Rakesh Sankaranarayanan
2023-02-17 17:08   ` Vladimir Oltean
2023-02-21  7:14     ` Rakesh.Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac " Rakesh Sankaranarayanan
2023-02-17 15:01   ` Alexander Lobakin
2023-02-17 16:42     ` Vladimir Oltean
2023-02-24 16:07       ` Alexander Lobakin
2023-02-24 21:53         ` Vladimir Oltean
2023-02-27 14:31           ` Alexander Lobakin
2023-02-27 14:52             ` Andrew Lunn
2023-02-28 10:53               ` Alexander Lobakin
2023-02-17 11:02 ` [PATCH v2 net-next 4/5] net: dsa: microchip: add eth phy " Rakesh Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 5/5] net: dsa: microchip: remove num_alus_variable Rakesh Sankaranarayanan
2023-02-17 17:16   ` Vladimir Oltean
2023-02-21  7:25     ` Rakesh.Sankaranarayanan
2023-02-17 14:54 ` [PATCH v2 net-next 0/5] add ethtool categorized statistics Alexander Lobakin
2023-02-17 16:48   ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230217165346.2eaualia32kmliz6@skbuf \
    --to=olteanv@gmail.com \
    --cc=Thangaraj.S@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rakesh.sankaranarayanan@microchip.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).