From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D78C678D5 for ; Sat, 18 Feb 2023 09:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229784AbjBRJFt (ORCPT ); Sat, 18 Feb 2023 04:05:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229795AbjBRJFf (ORCPT ); Sat, 18 Feb 2023 04:05:35 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFADD4C3CB for ; Sat, 18 Feb 2023 01:05:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 51031B80185 for ; Sat, 18 Feb 2023 09:05:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F32AEC4339B; Sat, 18 Feb 2023 09:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676711132; bh=x++jBRaTZGnOQ9PO88b3zGVLWstLbzQWIwb07kKF37k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qm9VAJ2D0sSCs6fvcpKS4viSi0CHatdKIjSPBOFJXJPtx99PpQS4P/lav2CouBhBa zyBU3qnKLFneNENapAPEOMpOBvAEyLC/uGQpfYkEhAuHPMLL3J3fwVrIedr8Hw0tIZ kBoi8+AQGH9wl3Yvl92uxfG9/cC5CXv5DItCS0dLSo+H8vSvScH2/+T0fkG8i1e45x YX2OkwhqrCMTHIKmnZT1p2ttbnmxuiGVTn8Ae+sRvUccSlJhZM+nrMUOJy+3dLc3eY Pz7dJe22Sd5RI396ANsvVLanUSMYZEsj/frhEO7xpGHTApDKGsI7B2Ja8Rk4KKUMr2 YN8Q4Q3ATj+fA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Gal Pressman , Maciej Fijalkowski Subject: [net-next V2 9/9] net/mlx5e: RX, Remove doubtful unlikely call Date: Sat, 18 Feb 2023 01:05:13 -0800 Message-Id: <20230218090513.284718-10-saeed@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230218090513.284718-1-saeed@kernel.org> References: <20230218090513.284718-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Gal Pressman When building an skb in non-linear mode, it is not likely nor unlikely that the xdp buff has fragments, it depends on the size of the packet received. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed Reviewed-by: Maciej Fijalkowski --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 8e64f4b48d53..15d9932f741d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c @@ -1718,7 +1718,7 @@ mlx5e_skb_from_cqe_nonlinear(struct mlx5e_rq *rq, struct mlx5e_wqe_frag_info *wi page_ref_inc(head_wi->au->page); - if (unlikely(xdp_buff_has_frags(&mxbuf.xdp))) { + if (xdp_buff_has_frags(&mxbuf.xdp)) { int i; /* sinfo->nr_frags is reset by build_skb, calculate again. */ -- 2.39.1