From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <richardcochran@gmail.com>
Subject: Re: [PATCH net-next] net: phy: micrel: Add support for PTP_PF_PEROUT for lan8841
Date: Sat, 18 Feb 2023 13:10:39 +0100 [thread overview]
Message-ID: <20230218121039.4kgejvhbi4ppkij6@soft-dev3-1> (raw)
In-Reply-To: <Y/Ah/MRYKdohtXZH@lunn.ch>
The 02/18/2023 01:55, Andrew Lunn wrote:
>
> > +static void lan8841_ptp_update_target(struct kszphy_ptp_priv *ptp_priv,
> > + const struct timespec64 *ts);
> > +
>
> Please avoid this. Move the code around so everything is in
> order. Generally, i do such moves in an initial patch which only moves
> code, making it easy to review.
Thanks for the suggestion. I will update this in the next version.
>
> Andrew
--
/Horatiu
prev parent reply other threads:[~2023-02-18 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 7:52 [PATCH net-next] net: phy: micrel: Add support for PTP_PF_PEROUT for lan8841 Horatiu Vultur
2023-02-17 13:30 ` Russell King (Oracle)
2023-02-17 13:33 ` Russell King (Oracle)
2023-02-17 15:02 ` Horatiu Vultur
2023-02-18 0:55 ` Andrew Lunn
2023-02-18 12:10 ` Horatiu Vultur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230218121039.4kgejvhbi4ppkij6@soft-dev3-1 \
--to=horatiu.vultur@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox