From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Ferenc Fejes <fejes@inf.elte.hu>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Gerhard Engleder <gerhard@engleder-embedded.com>,
Amritha Nambiar <amritha.nambiar@intel.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Roger Quadros <rogerq@kernel.org>,
Pranavi Somisetty <pranavi.somisetty@amd.com>,
Harini Katakam <harini.katakam@amd.com>,
linux-kernel@vger.kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Wong Vee Khee <vee.khee.wong@linux.intel.com>,
Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH v2 net-next 00/12] Add tc-mqprio and tc-taprio support for preemptible traffic classes
Date: Mon, 20 Feb 2023 13:48:16 +0200 [thread overview]
Message-ID: <20230220114816.vfpabqxmkq4zul24@skbuf> (raw)
In-Reply-To: <d016f61224b293a77969c35d09d65d5cfea7d137.camel@inf.elte.hu>
On Mon, Feb 20, 2023 at 12:15:57PM +0100, Ferenc Fejes wrote:
> LGTM.
>
> Reviewed-by: Ferenc Fejes <fejes@inf.elte.hu>
Thanks a lot for the review!
Unfortunately I need to send a v3, because the C language apparently
doesn't like "default" switch cases with no code, and I need to make
this change (which surprises me, since the code did compile fine with
my gcc-arm-11.2-2022.02-x86_64-aarch64-none-linux-gnu toolchain):
diff --git a/drivers/net/ethernet/mscc/ocelot_mm.c b/drivers/net/ethernet/mscc/ocelot_mm.c
index 21d5656dfc70..f7766927bdd2 100644
--- a/drivers/net/ethernet/mscc/ocelot_mm.c
+++ b/drivers/net/ethernet/mscc/ocelot_mm.c
@@ -57,20 +57,16 @@ void ocelot_port_update_preemptible_tcs(struct ocelot *ocelot, int port)
lockdep_assert_held(&mm->lock);
- /* On NXP LS1028A, when using QSGMII, the port hangs if transmitting
- * preemptible frames at any other link speed than gigabit
+ /* Only commit preemptible TCs when MAC Merge is active.
+ * On NXP LS1028A, when using QSGMII, the port hangs if transmitting
+ * preemptible frames at any other link speed than gigabit, so avoid
+ * preemption at lower speeds in this PHY mode.
*/
- if (ocelot_port->phy_mode != PHY_INTERFACE_MODE_QSGMII ||
- ocelot_port->speed == SPEED_1000) {
- /* Only commit preemptible TCs when MAC Merge is active */
- switch (mm->verify_status) {
- case ETHTOOL_MM_VERIFY_STATUS_SUCCEEDED:
- case ETHTOOL_MM_VERIFY_STATUS_DISABLED:
- val = mm->preemptible_tcs;
- break;
- default:
- }
- }
+ if ((ocelot_port->phy_mode != PHY_INTERFACE_MODE_QSGMII ||
+ ocelot_port->speed == SPEED_1000) &&
+ (mm->verify_status == ETHTOOL_MM_VERIFY_STATUS_SUCCEEDED ||
+ mm->verify_status == ETHTOOL_MM_VERIFY_STATUS_DISABLED))
+ val = mm->preemptible_tcs;
ocelot_rmw_rix(ocelot, QSYS_PREEMPTION_CFG_P_QUEUES(val),
QSYS_PREEMPTION_CFG_P_QUEUES_M,
Besides, I'm also taking the opportunity to make one more change, and
really do a thorough job with the netlink extack: I will be passing it
down to the device driver in v3, via struct tc_mqprio_qopt_offload and
struct tc_taprio_qopt_offload.
I'll replicate your review tag for all patches from v2 that will be
present in an unchanged form in v3, ok?
next prev parent reply other threads:[~2023-02-20 11:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 13:52 [PATCH v2 net-next 00/12] Add tc-mqprio and tc-taprio support for preemptible traffic classes Vladimir Oltean
2023-02-19 13:52 ` [PATCH v2 net-next 01/12] net: enetc: rename "mqprio" to "qopt" Vladimir Oltean
2023-02-19 13:52 ` [PATCH v2 net-next 02/12] net: mscc: ocelot: add support for mqprio offload Vladimir Oltean
2023-02-19 13:52 ` [PATCH v2 net-next 03/12] net: dsa: felix: act upon the mqprio qopt in taprio offload Vladimir Oltean
2023-02-19 13:53 ` [PATCH v2 net-next 04/12] net: ethtool: fix __ethtool_dev_mm_supported() implementation Vladimir Oltean
2023-02-20 11:50 ` Kurt Kanzenbach
2023-02-20 11:55 ` Vladimir Oltean
2023-02-19 13:53 ` [PATCH v2 net-next 05/12] net: ethtool: create and export ethtool_dev_mm_supported() Vladimir Oltean
2023-02-19 13:53 ` [PATCH v2 net-next 06/12] net/sched: mqprio: simplify handling of nlattr portion of TCA_OPTIONS Vladimir Oltean
2023-02-19 13:53 ` [PATCH v2 net-next 07/12] net/sched: mqprio: add extack to mqprio_parse_nlattr() Vladimir Oltean
2023-02-19 13:53 ` [PATCH v2 net-next 08/12] net/sched: mqprio: add an extack message to mqprio_parse_opt() Vladimir Oltean
2023-02-19 13:53 ` [PATCH v2 net-next 09/12] net/sched: mqprio: allow per-TC user input of FP adminStatus Vladimir Oltean
2023-02-19 13:53 ` [PATCH v2 net-next 10/12] net/sched: taprio: " Vladimir Oltean
2023-02-19 13:53 ` [PATCH v2 net-next 11/12] net: mscc: ocelot: add support for preemptible traffic classes Vladimir Oltean
2023-02-19 13:53 ` [PATCH v2 net-next 12/12] net: enetc: " Vladimir Oltean
2023-02-20 11:15 ` [PATCH v2 net-next 00/12] Add tc-mqprio and tc-taprio " Ferenc Fejes
2023-02-20 11:48 ` Vladimir Oltean [this message]
2023-02-20 12:05 ` Ferenc Fejes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220114816.vfpabqxmkq4zul24@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amritha.nambiar@intel.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=fejes@inf.elte.hu \
--cc=gerhard@engleder-embedded.com \
--cc=harini.katakam@amd.com \
--cc=jacob.e.keller@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.wei.hong.sit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=pranavi.somisetty@amd.com \
--cc=rogerq@kernel.org \
--cc=vee.khee.wong@linux.intel.com \
--cc=vinicius.gomes@intel.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox