From: Jakub Kicinski <kuba@kernel.org>
To: "Íñigo Huguet" <ihuguet@redhat.com>
Cc: ecree.xilinx@gmail.com, habetsm.xilinx@gmail.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
richardcochran@gmail.com, netdev@vger.kernel.org,
Yalin Li <yalli@redhat.com>
Subject: Re: [PATCH net-next v4 0/4] sfc: support unicast PTP
Date: Tue, 21 Feb 2023 08:25:50 -0800 [thread overview]
Message-ID: <20230221082550.5f694cce@kernel.org> (raw)
In-Reply-To: <20230221125217.20775-1-ihuguet@redhat.com>
On Tue, 21 Feb 2023 13:52:13 +0100 Íñigo Huguet wrote:
> Unicast PTP was not working with sfc NICs.
>
> The reason was that these NICs don't timestamp all incoming packets,
> but instead they only timestamp packets of the queues that are selected
> for that. Currently, only one RX queue is configured for timestamp: the
> RX queue of the PTP channel. The packets that are put in the PTP RX
> queue are selected according to firmware filters configured from the
> driver.
>
> Multicast PTP was already working because the needed filters are known
> in advance, so they're inserted when PTP is enabled. This patches
> add the ability to dynamically add filters for unicast addresses,
> extracted from the TX PTP-event packets.
>
> Since we don't know in advance how many filters we'll need, some info
> about the filters need to be saved. This will allow to check if a filter
> already exists or if a filter is too old and should be removed.
>
> Note that the previous point is unnecessary for multicast filters, but
> I've opted to change how they're handled to match the new unicast's
> filters to avoid having duplicate insert/remove_filters functions,
> once for each type of filter.
>
> Tested: With ptp4l, all combinations of IPv4/IPv6, master/slave and
> unicast/multicast
# Form letter - net-next is closed
The merge window for v6.3 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.
Please repost when net-next reopens after Mar 6th.
RFC patches sent for review only are obviously welcome at any time.
next prev parent reply other threads:[~2023-02-21 16:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 12:52 [PATCH net-next v4 0/4] sfc: support unicast PTP Íñigo Huguet
2023-02-21 12:52 ` [PATCH net-next v4 1/4] sfc: store PTP filters in a list Íñigo Huguet
2023-02-21 12:52 ` [PATCH net-next v4 2/4] sfc: allow insertion of filters for unicast PTP Íñigo Huguet
2023-02-21 12:52 ` [PATCH net-next v4 3/4] sfc: support " Íñigo Huguet
2023-02-22 14:20 ` Vadim Fedorenko
2023-02-22 14:41 ` Íñigo Huguet
2023-02-22 16:52 ` Richard Cochran
2023-02-23 13:08 ` Íñigo Huguet
2023-02-24 9:01 ` Martin Habets
2023-02-24 15:43 ` Richard Cochran
2023-02-24 15:58 ` Richard Cochran
2023-02-21 12:52 ` [PATCH net-next v4 4/4] sfc: remove expired unicast PTP filters Íñigo Huguet
2023-02-21 16:25 ` Jakub Kicinski [this message]
2023-02-22 9:24 ` [PATCH net-next v4 0/4] sfc: support unicast PTP Martin Habets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221082550.5f694cce@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=ihuguet@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=yalli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).