From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Patrisious Haddad <phaddad@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
linux-rdma@vger.kernel.org, Mark Zhang <markzhang@nvidia.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Raed Salem <raeds@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH net-next] net/mlx5: Fix memory leak in IPsec RoCE creation
Date: Tue, 21 Feb 2023 08:30:06 -0800 [thread overview]
Message-ID: <20230221083006.012507c3@kernel.org> (raw)
In-Reply-To: <Y/RnLCPZPaR4WSUC@unreal>
On Tue, 21 Feb 2023 08:39:40 +0200 Leon Romanovsky wrote:
> On Mon, Feb 20, 2023 at 04:50:00PM -0800, Jakub Kicinski wrote:
> > On Sun, 19 Feb 2023 14:59:57 +0200 Leon Romanovsky wrote:
> > > -rule_fail:
> > > +fail_rule:
> > > mlx5_destroy_flow_group(roce->g);
> > > -fail:
> > > +fail_group:
> > > mlx5_destroy_flow_table(ft);
> > > +fail_table:
> > > + kvfree(in);
> > > return err;
> >
> > If you're touching all of them please name them after what they do.
> > Much easier to review.
>
> I can change it, but all mlx* drivers and randomly chosen place in ice
> use label to show what fail and not what will be done. Such notation
> gives an ability to refactor code without changing label names if
> failed part of code is not removed.
Please refactor, and it'd be great if the convention was changed for
all new code in these drivers.
prev parent reply other threads:[~2023-02-21 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 12:59 [PATCH net-next] net/mlx5: Fix memory leak in IPsec RoCE creation Leon Romanovsky
2023-02-21 0:50 ` Jakub Kicinski
2023-02-21 6:39 ` Leon Romanovsky
2023-02-21 16:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221083006.012507c3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phaddad@nvidia.com \
--cc=raeds@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).