From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
<davem@davemloft.net>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>
Subject: Re: [PULL] Networking for v6.3
Date: Wed, 22 Feb 2023 11:33:34 -0800 [thread overview]
Message-ID: <20230222113334.0fb37d5f@kernel.org> (raw)
In-Reply-To: <d04f822b-ac63-7f45-ef4d-978876d57307@intel.com>
On Wed, 22 Feb 2023 20:07:21 +0100 Alexander Lobakin wrote:
> > I suspect it would be as simple as adding a
> >
> > depends on ICE != n
> >
> > to that thing, but I didn't get around to testing that. I thought it
> > would be better to notify the guilty parties.
>
> Patch is on its way already, it just drops the opt and uses CONFIG_GNSS
> directly.
You got me slightly worried now. The overall idea of using Kconfig
to resolve the dependency and compile out the entire file was right.
Are you planing to wrap the entire source in IS_REACHABLE() ?
next prev parent reply other threads:[~2023-02-22 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 23:38 [PULL] Networking for v6.3 Jakub Kicinski
2023-02-22 2:46 ` Linus Torvalds
2023-02-22 3:33 ` Jakub Kicinski
2023-02-22 19:07 ` Alexander Lobakin
2023-02-22 19:33 ` Jakub Kicinski [this message]
2023-02-22 22:26 ` Jacob Keller
2023-02-22 2:50 ` pr-tracker-bot
2023-02-23 17:21 ` Linus Torvalds
2023-02-23 19:06 ` Kalle Valo
2023-02-23 21:37 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222113334.0fb37d5f@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).