From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB1DC61DA4 for ; Thu, 23 Feb 2023 05:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232357AbjBWFR5 (ORCPT ); Thu, 23 Feb 2023 00:17:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233136AbjBWFRy (ORCPT ); Thu, 23 Feb 2023 00:17:54 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A14B43D934 for ; Wed, 22 Feb 2023 21:17:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 96985B811EC for ; Thu, 23 Feb 2023 05:17:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7DB2C433EF; Thu, 23 Feb 2023 05:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677129464; bh=RUHLDq+BwbTgrH2AUtwXvSW4iEa6Ln7BXuRs6xH1iSw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g0elYqauO5caCzGeCrmOL4AtbSzAa9qSJNFIanZxRVXSKMvFkMvgil8FdqSqSNQnK tT1axI8lp+SmKfvxmoI/OU3ZadX7PvD47Tl28v/FacYNAf8yBffOsWLyy9seguwZ0N K7NXR0exlvQ7jNlOCUoewMbNzCLd32lpKsFIjJG2zZwi7e2XOW/NB1Gckz6XGYsffk l4ZF8HMuhyauCYBM4vvjqJTEKm0dov7XTL0St9LoJE7fldX6KupnEEmOcOzEdizDVc QPsTSyJB7YazscZDa8ZH5yoZ3AeHYhpPrkH9YIXo1s9UWi2wSuzsvlfRdRw9FH9IMC m9CpNVRlxlK3g== Date: Wed, 22 Feb 2023 21:17:42 -0800 From: Jakub Kicinski To: Jacob Keller Cc: Intel Wired LAN , netdev@vger.kernel.org, Linus Torvalds , Arkadiusz Kubalewski , Alexander Lobakin , Anthony Nguyen Subject: Re: [intel-net] ice: remove unnecessary CONFIG_ICE_GNSS Message-ID: <20230222211742.4000f650@kernel.org> In-Reply-To: <20230222223558.2328428-1-jacob.e.keller@intel.com> References: <20230222223558.2328428-1-jacob.e.keller@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 22 Feb 2023 14:35:58 -0800 Jacob Keller wrote: > I'm sending to both Intel-wired-lan and netdev lists since this was > discussed publicly on the netdev list. I'm not sure how we want to queue it > up, so I currently have it tagged as intel-net to go through Tony's IWL > tree. I'm happy however it gets pulled. I believe this is the best solution > as the total number of #ifdefs is the same as with CONFIG_ICE_GNSS, as is > the Makefile line. As far as I can tell the Kbuild just does the right thing > here so there is no need for an additional flag. > > I'm happy to respin with a "depends" check if we think the flag has other > value. Sorry for late response. Do you mean depends as in keeping the separate Kconfig? IS_REACHABLE() is a bit of a hack, makes figuring out what gets built a lot harder for users. How about we keep the IS_ENABLED() but add a dependency to ICE as a whole? I mean instead of s/IS_ENABLED/IS_REACHABLE/ do this: index 3facb55b7161..198995b3eab5 100644 --- a/drivers/net/ethernet/intel/Kconfig +++ b/drivers/net/ethernet/intel/Kconfig @@ -296,6 +296,7 @@ config ICE default n depends on PCI_MSI depends on PTP_1588_CLOCK_OPTIONAL + depends on GNSS || GNSS=n select AUXILIARY_BUS select DIMLIB select NET_DEVLINK Or do you really care about building ICE with no GNSS.. ?