From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Maxim Mikityanskiy <maxtram95@gmail.com>
Subject: Re: [net 03/10] net/mlx5e: XDP, Allow growing tail for XDP multi buffer
Date: Thu, 23 Feb 2023 16:34:14 -0800 [thread overview]
Message-ID: <20230223163414.6d860ecd@kernel.org> (raw)
In-Reply-To: <20230223225247.586552-4-saeed@kernel.org>
On Thu, 23 Feb 2023 14:52:40 -0800 Saeed Mahameed wrote:
> From: Maxim Mikityanskiy <maxtram95@gmail.com>
>
> The cited commits missed passing frag_size to __xdp_rxq_info_reg, which
> is required by bpf_xdp_adjust_tail to support growing the tail pointer
> in fragmented packets. Pass the missing parameter when the current RQ
> mode allows XDP multi buffer.
Why is this a fix and not an (omitted) feature?
next prev parent reply other threads:[~2023-02-24 0:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 22:52 [pull request][net 00/10] mlx5 fixes 2023-02-23 Saeed Mahameed
2023-02-23 22:52 ` [net 01/10] net/mlx5: Remove NULL check before dev_{put, hold} Saeed Mahameed
2023-02-23 22:52 ` [net 02/10] net/mlx5e: TC, fix return value check in mlx5e_tc_act_stats_create() Saeed Mahameed
2023-02-23 22:52 ` [net 03/10] net/mlx5e: XDP, Allow growing tail for XDP multi buffer Saeed Mahameed
2023-02-24 0:34 ` Jakub Kicinski [this message]
2023-02-24 18:07 ` Saeed Mahameed
2023-04-08 11:24 ` Maxim Mikityanskiy
2023-02-23 22:52 ` [net 04/10] net/mlx5e: xsk: Set napi_id to support busy polling on XSK RQ Saeed Mahameed
2023-02-24 0:35 ` Jakub Kicinski
2023-02-23 22:52 ` [net 05/10] mlx5: fix skb leak while fifo resync and push Saeed Mahameed
2023-02-23 22:52 ` [net 06/10] mlx5: fix possible ptp queue fifo use-after-free Saeed Mahameed
2023-02-23 22:52 ` [net 07/10] net/mlx5e: Correct SKB room check to use all room in the fifo Saeed Mahameed
2023-02-24 0:38 ` Jakub Kicinski
2023-02-24 12:18 ` Vadim Fedorenko
2023-02-24 18:03 ` Saeed Mahameed
2023-02-24 21:58 ` David Laight
2023-02-23 22:52 ` [net 08/10] net/mlx5: ECPF, wait for VF pages only after disabling host PFs Saeed Mahameed
2023-02-23 22:52 ` [net 09/10] net/mlx5e: Verify flow_source cap before using it Saeed Mahameed
2023-02-23 22:52 ` [net 10/10] net/mlx5: Geneve, Fix handling of Geneve object id as error code Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223163414.6d860ecd@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=maxtram95@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).