From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
"David S. Miller" <davem@davemloft.net>,
Andi Shyti <andi.shyti@linux.intel.com>,
Andrzej Hajda <andrzej.hajda@intel.com>
Subject: [PATCH v6 4/8] lib/ref_tracker: remove warnings in case of allocation failure
Date: Wed, 29 Mar 2023 09:24:15 +0200 [thread overview]
Message-ID: <20230224-track_gt-v6-4-0dc8601fd02f@intel.com> (raw)
In-Reply-To: <20230224-track_gt-v6-0-0dc8601fd02f@intel.com>
Library can handle allocation failures. To avoid allocation warnings
__GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been
replaced with GFP_NOWAIT in case of stack allocation on tracker free
call.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
---
lib/ref_tracker.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
index cce4614b07940f..cf5609b1ca7936 100644
--- a/lib/ref_tracker.c
+++ b/lib/ref_tracker.c
@@ -189,7 +189,7 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir,
unsigned long entries[REF_TRACKER_STACK_ENTRIES];
struct ref_tracker *tracker;
unsigned int nr_entries;
- gfp_t gfp_mask = gfp;
+ gfp_t gfp_mask = gfp | __GFP_NOWARN;
unsigned long flags;
WARN_ON_ONCE(dir->dead);
@@ -237,7 +237,8 @@ int ref_tracker_free(struct ref_tracker_dir *dir,
return -EEXIST;
}
nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 1);
- stack_handle = stack_depot_save(entries, nr_entries, GFP_ATOMIC);
+ stack_handle = stack_depot_save(entries, nr_entries,
+ GFP_NOWAIT | __GFP_NOWARN);
spin_lock_irqsave(&dir->lock, flags);
if (tracker->dead) {
--
2.34.1
next prev parent reply other threads:[~2023-03-29 7:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 7:24 [PATCH v6 0/8] drm/i915: use ref_tracker library for tracking wakerefs Andrzej Hajda
2023-03-29 7:24 ` [PATCH v6 1/8] lib/ref_tracker: add unlocked leak print helper Andrzej Hajda
2023-03-29 12:35 ` Andi Shyti
2023-03-29 7:24 ` [PATCH v6 2/8] lib/ref_tracker: improve printing stats Andrzej Hajda
2023-03-29 12:51 ` Andi Shyti
2023-03-29 7:24 ` [PATCH v6 3/8] lib/ref_tracker: add printing to memory buffer Andrzej Hajda
2023-03-29 12:56 ` Andi Shyti
2023-03-29 7:24 ` Andrzej Hajda [this message]
2023-03-29 7:24 ` [PATCH v6 5/8] drm/i915: Correct type of wakeref variable Andrzej Hajda
2023-03-29 7:24 ` [PATCH v6 6/8] drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library Andrzej Hajda
2023-03-29 7:24 ` [PATCH v6 7/8] drm/i915: track gt pm wakerefs Andrzej Hajda
2023-03-29 7:24 ` [PATCH v6 8/8] drm/i915/gt: Hold a wakeref for the active VM Andrzej Hajda
2023-03-29 13:01 ` [PATCH v6 0/8] drm/i915: use ref_tracker library for tracking wakerefs Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224-track_gt-v6-4-0dc8601fd02f@intel.com \
--to=andrzej.hajda@intel.com \
--cc=airlied@gmail.com \
--cc=andi.shyti@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).