From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2D49C6FA8E for ; Fri, 24 Feb 2023 18:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbjBXSTl (ORCPT ); Fri, 24 Feb 2023 13:19:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229880AbjBXSTc (ORCPT ); Fri, 24 Feb 2023 13:19:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A0BF15CA9 for ; Fri, 24 Feb 2023 10:19:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B1E766195E for ; Fri, 24 Feb 2023 18:19:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B79AC433D2; Fri, 24 Feb 2023 18:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677262759; bh=WKP6ruUbcNyu8tZohOWu+hFnIbAbyBrqkPI+HAxSAag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PVaht458ALYzl2wMcZ8T/KyaurwD4K17p+DhpupVNj/QLYbopd1Y0HxMVMAS93pIv rcDFR9/zaKekYg8QEybaL+WtGz71xFLa2ebrXJ3bXoRIoYFddqHVs3lfapUe7FcrBY S6ll+Wq8fn1nXC5IACkqim0Kk9SqV594kDZQG7VExbXC0Zxegxo+O8iql8xTD+2MFm 6JxX60c8ktg/I49bIHjH7tm8t+vzV43H2Wt2TtoX41s2TJUs4lm5p9cqkm6wy46PQX IOrLM+GuszN1qPj436L1dgRhTpnqfEvGOrEDIdnrC5qUTCbPWc/C54WTmKYj0G+XA/ /AI4aV0KJFqlA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Maor Dickman , Raed Salem Subject: [net V2 7/7] net/mlx5: Geneve, Fix handling of Geneve object id as error code Date: Fri, 24 Feb 2023 10:19:04 -0800 Message-Id: <20230224181904.671473-8-saeed@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230224181904.671473-1-saeed@kernel.org> References: <20230224181904.671473-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maor Dickman On success, mlx5_geneve_tlv_option_create returns non negative Geneve object id. In case the object id is positive value the caller functions will handle it as an error (non zero) and will fail to offload the Geneve rule. Fix this by changing caller function ,mlx5_geneve_tlv_option_add, to return 0 in case valid non negative object id was provided. Fixes: 0ccc171ea6a2 ("net/mlx5: Geneve, Manage Geneve TLV options") Signed-off-by: Maor Dickman Reviewed-by: Raed Salem Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lib/geneve.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/geneve.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/geneve.c index 23361a9ae4fa..6dc83e871cd7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/geneve.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/geneve.c @@ -105,6 +105,7 @@ int mlx5_geneve_tlv_option_add(struct mlx5_geneve *geneve, struct geneve_opt *op geneve->opt_type = opt->type; geneve->obj_id = res; geneve->refcount++; + res = 0; } unlock: -- 2.39.1