From: Jakub Kicinski <kuba@kernel.org>
To: nick black <dankamongmen@gmail.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jeffrey Ji <jeffreyji@google.com>,
Eric Dumazet <edumazet@google.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH] [net] add rx_otherhost_dropped sysfs entry
Date: Mon, 27 Feb 2023 10:23:39 -0800 [thread overview]
Message-ID: <20230227102339.08ddf3fb@kernel.org> (raw)
In-Reply-To: <Y/p5sDErhHtzW03E@schwarzgerat.orthanc>
On Sat, 25 Feb 2023 16:12:16 -0500 nick black wrote:
> Add the sysfs export for rx_otherhost_dropped, added
> in 794c24e9921f ("rx_otherhost_dropped to core_stats").
> All other rtnl_link_stats64 entries are already present
> as sysfs nodes; this completes the set.
"All the other stats are there" is not a strong enough reason
to waste memory on all systems. You need to justify the change
based on how important the counter is. I'd prefer to draw a
line on adding the sysfs stats entries. We don't want to have
to invent a new stats struct just to avoid having sysfs entries
for each stat.
next prev parent reply other threads:[~2023-02-27 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 21:12 [PATCH] [net] add rx_otherhost_dropped sysfs entry nick black
2023-02-27 18:23 ` Jakub Kicinski [this message]
2023-02-27 18:29 ` nick black
2023-02-27 18:35 ` Eric Dumazet
2023-02-27 18:40 ` Jakub Kicinski
2023-02-28 12:59 ` nick black
2023-02-28 13:08 ` nick black
2023-02-28 20:33 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227102339.08ddf3fb@kernel.org \
--to=kuba@kernel.org \
--cc=dankamongmen@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jeffreyji@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).