* [PATCH 13/27] mctp: remove MODULE_LICENSE in non-modules [not found] <20230224150811.80316-1-nick.alcock@oracle.com> @ 2023-02-24 15:07 ` Nick Alcock 2023-02-24 15:08 ` [PATCH 27/27] lib: packing: " Nick Alcock 1 sibling, 0 replies; 4+ messages in thread From: Nick Alcock @ 2023-02-24 15:07 UTC (permalink / raw) To: mcgrof Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Jeremy Kerr, Matt Johnston, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message. So remove it in the files in this commit, none of which can be built as modules. Signed-off-by: Nick Alcock <nick.alcock@oracle.com> Suggested-by: Luis Chamberlain <mcgrof@kernel.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> Cc: Jeremy Kerr <jk@codeconstruct.com.au> Cc: Matt Johnston <matt@codeconstruct.com.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: netdev@vger.kernel.org --- net/mctp/af_mctp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/mctp/af_mctp.c b/net/mctp/af_mctp.c index fc9e728b6333..2e763c398e92 100644 --- a/net/mctp/af_mctp.c +++ b/net/mctp/af_mctp.c @@ -694,7 +694,6 @@ subsys_initcall(mctp_init); module_exit(mctp_exit); MODULE_DESCRIPTION("MCTP core"); -MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Jeremy Kerr <jk@codeconstruct.com.au>"); MODULE_ALIAS_NETPROTO(PF_MCTP); -- 2.39.1.268.g9de2f9a303 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 27/27] lib: packing: remove MODULE_LICENSE in non-modules [not found] <20230224150811.80316-1-nick.alcock@oracle.com> 2023-02-24 15:07 ` [PATCH 13/27] mctp: remove MODULE_LICENSE in non-modules Nick Alcock @ 2023-02-24 15:08 ` Nick Alcock 2023-02-24 15:22 ` Vladimir Oltean 1 sibling, 1 reply; 4+ messages in thread From: Nick Alcock @ 2023-02-24 15:08 UTC (permalink / raw) To: mcgrof Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Vladimir Oltean, netdev Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message. So remove it in the files in this commit, none of which can be built as modules. Signed-off-by: Nick Alcock <nick.alcock@oracle.com> Suggested-by: Luis Chamberlain <mcgrof@kernel.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> Cc: Vladimir Oltean <olteanv@gmail.com> Cc: netdev@vger.kernel.org --- lib/packing.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/packing.c b/lib/packing.c index a96169237ae6..3f656167c17e 100644 --- a/lib/packing.c +++ b/lib/packing.c @@ -198,5 +198,4 @@ int packing(void *pbuf, u64 *uval, int startbit, int endbit, size_t pbuflen, } EXPORT_SYMBOL(packing); -MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("Generic bitfield packing and unpacking"); -- 2.39.1.268.g9de2f9a303 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 27/27] lib: packing: remove MODULE_LICENSE in non-modules 2023-02-24 15:08 ` [PATCH 27/27] lib: packing: " Nick Alcock @ 2023-02-24 15:22 ` Vladimir Oltean 2023-02-27 19:39 ` Jakub Kicinski 0 siblings, 1 reply; 4+ messages in thread From: Vladimir Oltean @ 2023-02-24 15:22 UTC (permalink / raw) To: Nick Alcock; +Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa, netdev On Fri, Feb 24, 2023 at 03:08:11PM +0000, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Vladimir Oltean <olteanv@gmail.com> > Cc: netdev@vger.kernel.org > --- > lib/packing.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/packing.c b/lib/packing.c > index a96169237ae6..3f656167c17e 100644 > --- a/lib/packing.c > +++ b/lib/packing.c > @@ -198,5 +198,4 @@ int packing(void *pbuf, u64 *uval, int startbit, int endbit, size_t pbuflen, > } > EXPORT_SYMBOL(packing); > > -MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("Generic bitfield packing and unpacking"); > -- > 2.39.1.268.g9de2f9a303 > Is this a bug fix? Does it need a Fixes: tag? How is it supposed to be merged? lib/packing.c is maintained by netdev, and I believe that netdev maintainers would prefer netdev patches to be submitted separately. Note that I was copied only on this patch, I haven't read the cover letter if that exists. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 27/27] lib: packing: remove MODULE_LICENSE in non-modules 2023-02-24 15:22 ` Vladimir Oltean @ 2023-02-27 19:39 ` Jakub Kicinski 0 siblings, 0 replies; 4+ messages in thread From: Jakub Kicinski @ 2023-02-27 19:39 UTC (permalink / raw) To: Nick Alcock Cc: Vladimir Oltean, mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa, netdev On Fri, 24 Feb 2023 17:22:14 +0200 Vladimir Oltean wrote: > Is this a bug fix? Does it need a Fixes: tag? How is it supposed to be > merged? lib/packing.c is maintained by netdev, and I believe that netdev > maintainers would prefer netdev patches to be submitted separately. As Vladimir said, if you repost just patches 13 and 27 of this series to netdev - we can take them in right away. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-27 19:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230224150811.80316-1-nick.alcock@oracle.com>
2023-02-24 15:07 ` [PATCH 13/27] mctp: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-24 15:08 ` [PATCH 27/27] lib: packing: " Nick Alcock
2023-02-24 15:22 ` Vladimir Oltean
2023-02-27 19:39 ` Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).