From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Alexander Lobakin <alexandr.lobakin@intel.com>
Subject: Re: [PATCH net 1/1] ice: remove unnecessary CONFIG_ICE_GNSS
Date: Mon, 27 Feb 2023 11:58:58 -0800 [thread overview]
Message-ID: <20230227115858.72c0ecd9@kernel.org> (raw)
In-Reply-To: <20230224213241.4025978-1-anthony.l.nguyen@intel.com>
On Fri, 24 Feb 2023 13:32:41 -0800 Tony Nguyen wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> CONFIG_ICE_GNSS was added by commit c7ef8221ca7d ("ice: use GNSS subsystem
> instead of TTY") as a way to allow the ice driver to optionally support
> GNSS features without forcing a dependency on CONFIG_GNSS.
>
> The original implementation of that commit at [1] used IS_REACHABLE. This
> was rejected by Olek at [2] with the suggested implementation of
> CONFIG_ICE_GNSS.
>
> Eventually after merging, Linus reported a .config which had
> CONFIG_ICE_GNSS = y when both GNSS = n and ICE = n. This confused him and
> he felt that the config option was not useful, and commented about it at
> [3].
Applied, thanks!
prev parent reply other threads:[~2023-02-27 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 21:32 [PATCH net 1/1] ice: remove unnecessary CONFIG_ICE_GNSS Tony Nguyen
2023-02-27 19:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227115858.72c0ecd9@kernel.org \
--to=kuba@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).