From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B17C64ED8 for ; Mon, 27 Feb 2023 20:04:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbjB0UE1 (ORCPT ); Mon, 27 Feb 2023 15:04:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbjB0UEZ (ORCPT ); Mon, 27 Feb 2023 15:04:25 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DDB81E9E0 for ; Mon, 27 Feb 2023 12:04:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A9DE8B80C94 for ; Mon, 27 Feb 2023 20:04:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7BECC433EF; Mon, 27 Feb 2023 20:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677528262; bh=UfNe+l1xTkSwmksrM0KXRGqemXoJq5vd5+jjeK57JtU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eCfJbgRROjKGbd5ftjznDS4ZJ8PPWqCoTZlvC58YL30IWMFi0nUXWpVqgEsEyQD7l UVZYfTLv204I9HFeWYp8RFLPlcPR/Y4ig8+ue8O8Yg1hDuYhTkk61/8/8gg3hkqk+P To85H5UaEyvgCFHKI+F8RnQbBxcX9aH+utfxeomAg32TojBExUjtr8MeN+E+tKKsfO zhovOhUnsr4XjwIu6aOR7kqtT7Au3NUk0hEVAHeqPTXdGE8wPC3SMgPKGyDFp8QA6R lIk09lTMM+6J3HIsiQR+6l2IK2cC8pZ4md3Ftwli6HAK51v++BF7N3NuhaUO8LUEwr 08haWzS0jRxsg== Date: Mon, 27 Feb 2023 12:04:20 -0800 From: Jakub Kicinski To: Jamal Hadi Salim Cc: Simon Horman , Pedro Tammela , netdev@vger.kernel.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, amir@vadai.me, dcaratti@redhat.com, willemb@google.com, ozsh@nvidia.com, paulb@nvidia.com Subject: Re: [PATCH net 1/3] net/sched: act_pedit: fix action bind logic Message-ID: <20230227120420.152a9b32@kernel.org> In-Reply-To: References: <20230224150058.149505-1-pctammela@mojatatu.com> <20230224150058.149505-2-pctammela@mojatatu.com> <20230227113641.574dd3bf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 27 Feb 2023 14:51:58 -0500 Jamal Hadi Salim wrote: > > > I agree that shouldn't be the case. > > > For me that doesn't make it a bug, but I don't feel strongly about it. > > > > I'm with Simon - this is a long standing problem, and we weren't getting > > any user complaints about this. So I also prefer to route this via > > net-next, without the Fixes tags. > > At minimum the pedit is a fix. How come? What makes pedit different? It's kinda hard to parse from the diff and the commit messages look copy/pasted. > The rest is toss-a-coin and put in net-next or net.