* [PATCH v2] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error
@ 2023-02-27 13:05 Tom Rix
2023-02-28 11:50 ` Paolo Abeni
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-02-27 13:05 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, steen.hegelund
Cc: netdev, linux-kernel, Tom Rix
A rand config causes this link error
drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open':
drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register'
lan743x_netdev_open is controlled by LAN743X
fixed_phy_register is controlled by FIXED_PHY
and the error happens when
CONFIG_LAN743X=y
CONFIG_FIXED_PHY=m
So LAN743X should also select FIXED_PHY
Signed-off-by: Tom Rix <trix@redhat.com>
---
v2: Add config setting that trigger the error to commit log
---
drivers/net/ethernet/microchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
index 24c994baad13..43ba71e82260 100644
--- a/drivers/net/ethernet/microchip/Kconfig
+++ b/drivers/net/ethernet/microchip/Kconfig
@@ -47,6 +47,7 @@ config LAN743X
depends on PCI
depends on PTP_1588_CLOCK_OPTIONAL
select PHYLIB
+ select FIXED_PHY
select CRC16
select CRC32
help
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error
2023-02-27 13:05 [PATCH v2] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error Tom Rix
@ 2023-02-28 11:50 ` Paolo Abeni
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Abeni @ 2023-02-28 11:50 UTC (permalink / raw)
To: Tom Rix, davem, edumazet, kuba, steen.hegelund; +Cc: netdev, linux-kernel
Hello,
On Mon, 2023-02-27 at 08:05 -0500, Tom Rix wrote:
> A rand config causes this link error
> drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open':
> drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register'
>
> lan743x_netdev_open is controlled by LAN743X
> fixed_phy_register is controlled by FIXED_PHY
>
> and the error happens when
> CONFIG_LAN743X=y
> CONFIG_FIXED_PHY=m
>
> So LAN743X should also select FIXED_PHY
>
> Signed-off-by: Tom Rix <trix@redhat.com>
You are targeting the -net tree, but this lacks a 'Fixes' tag, please
post a new version with such info.
If instead the intended target was net-next (as I think it was agreed
on previous revision) please repost after that net-next re-opens (in
~1w from now).
Thanks,
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-28 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-27 13:05 [PATCH v2] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error Tom Rix
2023-02-28 11:50 ` Paolo Abeni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).