From: Jakub Kicinski <kuba@kernel.org>
To: Tom Rix <trix@redhat.com>
Cc: Juergen Gross <jgross@suse.com>,
wei.liu@kernel.org, paul@xen.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen-netback: remove unused variables pending_idx and index
Date: Mon, 27 Feb 2023 15:35:03 -0800 [thread overview]
Message-ID: <20230227153503.3bc54eaf@kernel.org> (raw)
In-Reply-To: <f3f8584e-e97d-abe9-5749-da5bf3587a57@suse.com>
On Mon, 27 Feb 2023 09:29:30 +0100 Juergen Gross wrote:
> On 26.02.23 17:34, Tom Rix wrote:
> > building with gcc and W=1 reports
> > drivers/net/xen-netback/netback.c:886:21: error: variable
> > ‘pending_idx’ set but not used [-Werror=unused-but-set-variable]
> > 886 | u16 pending_idx;
> > | ^~~~~~~~~~~
> >
> > pending_idx is not used so remove it. Since index was only
> > used to set pending_idx, remove index as well.
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Applied, thanks!
next prev parent reply other threads:[~2023-02-27 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 16:34 [PATCH] xen-netback: remove unused variables pending_idx and index Tom Rix
2023-02-27 8:29 ` Juergen Gross
2023-02-27 23:35 ` Jakub Kicinski [this message]
2023-02-28 0:46 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227153503.3bc54eaf@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@xen.org \
--cc=trix@redhat.com \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).