From: Jakub Kicinski <kuba@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<leon@kernel.org>, <sgoutham@marvell.com>
Subject: Re: [net PATCH v1] octeontx2-af: Fix start and end bit for scan config
Date: Wed, 1 Mar 2023 20:51:58 -0800 [thread overview]
Message-ID: <20230301205158.4108dfc8@kernel.org> (raw)
In-Reply-To: <20230302041018.885758-1-rkannoth@marvell.com>
On Thu, 2 Mar 2023 09:40:18 +0530 Ratheesh Kannoth wrote:
> for_each_set_bit_from() needs start bit as one bit prior
> and end bit as one bit post position in the bit map
>
> Fixes: 812103edf670 (octeontx2-af: Exact match scan from kex profile)
You're still missing quotation marks. Preferred form is:
Fixes: 812103edf670 ("octeontx2-af: Exact match scan from kex profile")
You're also missing a change log.
More importantly please read the rules:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
Take a couple of days to think about checking your patches before
posting them, and how spamming patches hurts the project.
Repost this next week.
prev parent reply other threads:[~2023-03-02 4:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 4:10 [net PATCH v1] octeontx2-af: Fix start and end bit for scan config Ratheesh Kannoth
2023-03-02 4:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301205158.4108dfc8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).