From: Jakub Kicinski <kuba@kernel.org>
To: Shay Agroskin <shayagr@amazon.com>
Cc: David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.com>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
Saeed Bshara <saeedb@amazon.com>, "Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Arinzon, David" <darinzon@amazon.com>,
"Itzko, Shahar" <itzko@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>
Subject: Re: [PATCH RFC v1 net-next 1/5] ethtool: Add support for configuring tx_push_buf_len
Date: Thu, 2 Mar 2023 09:10:03 -0800 [thread overview]
Message-ID: <20230302091003.6e4b1e11@kernel.org> (raw)
In-Reply-To: <pj41zledq742hf.fsf@u570694869fb251.ant.amazon.com>
On Thu, 2 Mar 2023 16:23:59 +0200 Shay Agroskin wrote:
> > Why gate both on kr->tx_push_buf_len and not current and max
> > separately?
> > Is kr->tx_push_buf_len == 0 never a valid setting?
>
> Hi, thanks for reviewing it
>
> There's actually no requirement that tx_push_buf_len needs to be >
> 0. I'll drop this check.
> It seems like the reply object gets zeroed at
> ethnl_init_reply_data() so ENA can simply not touch this field if
> no push buffer exists, leaving the values at 0.
Maybe gate them based on driver supported features?
Save the supported during prep so we don't need to find ops again,
and only report if needed. No point spamming outputs with 0 on all
devices.
next prev parent reply other threads:[~2023-03-02 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 17:59 [PATCH RFC v1 net-next 0/5] Add tx push buf len param to ethtool Shay Agroskin
2023-03-01 17:59 ` [PATCH RFC v1 net-next 1/5] ethtool: Add support for configuring tx_push_buf_len Shay Agroskin
2023-03-02 4:00 ` Jakub Kicinski
2023-03-02 14:23 ` Shay Agroskin
2023-03-02 17:10 ` Jakub Kicinski [this message]
2023-03-01 17:59 ` [PATCH RFC v1 net-next 2/5] net: ena: Add an option to configure large LLQ headers Shay Agroskin
2023-03-01 17:59 ` [PATCH RFC v1 net-next 3/5] net: ena: Recalculate TX state variables every device reset Shay Agroskin
2023-03-01 17:59 ` [PATCH RFC v1 net-next 4/5] net: ena: Add support to changing tx_push_buf_len Shay Agroskin
2023-03-01 18:02 ` [PATCH RFC v1 net-next 5/5] net: ena: Advertise ETHTOOL_RING_USE_TX_PUSH_BUF_LEN support Shay Agroskin
2023-03-02 4:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302091003.6e4b1e11@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=itzko@amazon.com \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=osamaabb@amazon.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).