From: Leon Romanovsky <leon@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Michal Kubiak <michal.kubiak@intel.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND net v1 0/2] iavf: fix double-broken HW hash report
Date: Thu, 2 Mar 2023 11:10:08 +0200 [thread overview]
Message-ID: <20230302091008.GA561905@unreal> (raw)
In-Reply-To: <20230301115908.47995-1-aleksander.lobakin@intel.com>
On Wed, Mar 01, 2023 at 12:59:06PM +0100, Alexander Lobakin wrote:
> Currently, passing HW hash from descriptors to skb is broken two times.
> The first bug effectively disables hash from being filled at all, unless
> %NETIF_F_RXHASH is *disabled* via Ethtool. The second incorrectly says
> that IPv6 UDP packets are L3, which also triggers CPU hashing when
> needed (the networking core treats only L4 HW hash as "true").
> The very same problems were fixed in i40e and ice, but not in iavf,
> although each of the original commits bugged at least two drivers.
> It's never too late (I hope), so fix iavf this time.
>
> Alexander Lobakin (2):
> iavf: fix inverted Rx hash condition leading to disabled hash
> iavf: fix non-tunneled IPv6 UDP packet type and hashing
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
prev parent reply other threads:[~2023-03-02 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 11:59 [PATCH RESEND net v1 0/2] iavf: fix double-broken HW hash report Alexander Lobakin
2023-03-01 11:59 ` [PATCH RESEND net v1 1/2] iavf: fix inverted Rx hash condition leading to disabled hash Alexander Lobakin
2023-03-01 11:59 ` [PATCH RESEND net v1 2/2] iavf: fix non-tunneled IPv6 UDP packet type and hashing Alexander Lobakin
2023-03-02 9:10 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302091008.GA561905@unreal \
--to=leon@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).